Remove getProcessId/getSecretKey from Connection contract that is specific to PostgreSQL and instead use downcast.

Author: vietj

vertx-oracle-client/src/main/java/io/vertx/oracleclient/impl/OracleJdbcConnection.java

@@ -141,17 +141,7 @@ public void close(Holder holder, Completable<Void> promise) {
       context.runOnContext(v -> close(holder, promise));
     }
   }
-
-  @Override
-  public int getProcessId() {
-    throw new UnsupportedOperationException();
-  }
-
-  @Override
-  public int getSecretKey() {
-    throw new UnsupportedOperationException();
-  }
-
+  
   public Future<Void> afterAcquire() {
     PromiseInternal<Void> promise = context.owner().promise();
     context.<Void>executeBlocking(() -> {

vertx-pg-client/src/main/java/io/vertx/pgclient/impl/PgConnectionImpl.java

@@ -115,12 +115,14 @@ public PgConnection noticeHandler(Handler<PgNotice> handler) {
 
   @Override
   public int processId() {
-    return conn.getProcessId();
+    PgSocketConnection actual = (PgSocketConnection) conn.unwrap();
+    return actual.getProcessId();
   }
 
   @Override
   public int secretKey() {
-    return conn.getSecretKey();
+    PgSocketConnection actual = (PgSocketConnection) conn.unwrap();
+    return actual.getSecretKey();
   }
 
   @Override

vertx-pg-client/src/main/java/io/vertx/pgclient/impl/PgSocketConnection.java

@@ -125,12 +125,10 @@ protected void handleException(Throwable t) {
     }
   }
 
-  @Override
   public int getProcessId() {
     return processId;
   }
 
-  @Override
   public int getSecretKey() {
     return secretKey;
   }

vertx-sql-client/src/main/java/io/vertx/sqlclient/impl/SocketConnectionBase.java

@@ -170,16 +170,6 @@ public void init(Holder holder) {
     this.holder = holder;
   }
 
-  @Override
-  public int getProcessId() {
-    throw new UnsupportedOperationException();
-  }
-
-  @Override
-  public int getSecretKey() {
-    throw new UnsupportedOperationException();
-  }
-
   @Override
   public void close(Holder holder, Completable<Void> promise) {
     if (Vertx.currentContext() == context) {

vertx-sql-client/src/main/java/io/vertx/sqlclient/impl/pool/SqlConnectionPool.java

@@ -481,16 +481,6 @@ public void handleException(Throwable err) {
       }
     }
 
-    @Override
-    public int getProcessId() {
-      return conn.getProcessId();
-    }
-
-    @Override
-    public int getSecretKey() {
-      return conn.getSecretKey();
-    }
-
     @Override
     public Connection unwrap() {
       return conn;

vertx-sql-client/src/main/java/io/vertx/sqlclient/internal/Connection.java

@@ -63,10 +63,6 @@ default String system() {
 
   void close(Holder holder, Completable<Void> promise);
 
-  int getProcessId();
-
-  int getSecretKey();
-
   /**
    * The connection holder that handles connection interactions with the outer world, e.g. handling an event.
    */

vertx-sql-client/src/test/java/io/vertx/tests/sqlclient/spi/backend/GenericDriverTest.java

@@ -118,14 +118,6 @@ public void close(Holder holder, Completable<Void> promise) {
                 promise.succeed();
               }
               @Override
-              public int getProcessId() {
-                return 0;
-              }
-              @Override
-              public int getSecretKey() {
-                return 0;
-              }
-              @Override
               public <R> void schedule(CommandBase<R> cmd, Completable<R> handler) {
                 if (cmd instanceof SimpleQueryCommand) {
                   SimpleQueryCommand simpleQueryCmd = (SimpleQueryCommand) cmd;