fix(preferences): JS/TS settings now apply without restart

Previously only workspace-wide servers were notified (forProject(null)).
Now also notify per-project and per-document servers (open
projects/editors). Ensures TypeScript/JavaScript formatter and related
options take effect immediately.

Author: sebthom

org.eclipse.wildwebdeveloper/src/org/eclipse/wildwebdeveloper/ui/preferences/ProcessStreamConnectionProviderWithPreference.java

@@ -8,7 +8,7 @@
  * SPDX-License-Identifier: EPL-2.0
  *
  * Contributors:
- *  Angelo ZERR (Red Hat Inc.) - initial implementation
+ * Angelo ZERR (Red Hat Inc.) - initial implementation
  *******************************************************************************/
 package org.eclipse.wildwebdeveloper.ui.preferences;
 
@@ -18,24 +18,35 @@
 import java.util.HashMap;
 import java.util.Map;
 import java.util.Objects;
+import java.util.Set;
 import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ConcurrentHashMap;
 
+import org.eclipse.core.resources.ResourcesPlugin;
 import org.eclipse.jface.preference.IPreferenceStore;
+import org.eclipse.jface.text.IDocument;
 import org.eclipse.jface.util.IPropertyChangeListener;
 import org.eclipse.jface.util.PropertyChangeEvent;
+import org.eclipse.lsp4e.LSPEclipseUtils;
 import org.eclipse.lsp4e.LanguageServers;
 import org.eclipse.lsp4e.LanguageServersRegistry;
 import org.eclipse.lsp4e.LanguageServersRegistry.LanguageServerDefinition;
 import org.eclipse.lsp4e.server.ProcessStreamConnectionProvider;
 import org.eclipse.lsp4j.DidChangeConfigurationParams;
+import org.eclipse.lsp4j.services.LanguageServer;
 import org.eclipse.lsp4j.services.WorkspaceService;
+import org.eclipse.ui.IEditorPart;
+import org.eclipse.ui.IEditorReference;
+import org.eclipse.ui.IWorkbenchPage;
+import org.eclipse.ui.IWorkbenchWindow;
+import org.eclipse.ui.PlatformUI;
 
 /**
  * This class extends {@link ProcessStreamConnectionProvider} to manage
  * {@link IPreferenceStore} and call
  * {@link WorkspaceService#didChangeConfiguration(DidChangeConfigurationParams)}
  * when the preference store changes.
- * 
+ *
  */
 public abstract class ProcessStreamConnectionProviderWithPreference extends ProcessStreamConnectionProvider
 		implements IPropertyChangeListener {
@@ -162,9 +173,54 @@ public void propertyChange(PropertyChangeEvent event) {
 			@SuppressWarnings("rawtypes")
 			DidChangeConfigurationParams params = new DidChangeConfigurationParams(createSettings());
 
+			final Set<LanguageServer> notifiedServers = ConcurrentHashMap.newKeySet();
+
 			LanguageServers.forProject(null).withPreferredServer(languageServerDefinition).excludeInactive()
-					.collectAll((w, ls) -> CompletableFuture.completedFuture(ls)).thenAccept(
-							lss -> lss.stream().forEach(ls -> ls.getWorkspaceService().didChangeConfiguration(params)));
+					.collectAll((wrapper, server) -> {
+						if (languageServerDefinition.equals(wrapper.serverDefinition) && notifiedServers.add(server)) {
+							server.getWorkspaceService().didChangeConfiguration(params);
+						}
+						return CompletableFuture.completedFuture(null);
+					});
+
+			// also explicitly check project-scoped LS because `LanguageServers.forProject(null)` does not return LanguageServers
+			// that do not support supportsWorkspaceFolderCapability like JSTSLanguageServer. These LS do not pass the
+			// `LanguageServerWrapper.canOperate(IProject)` test with null project argument as used by `LanguageServers.forProject(null)`
+			for (final var project : ResourcesPlugin.getWorkspace().getRoot().getProjects()) {
+				if (!project.isOpen())
+					continue;
+
+				LanguageServers.forProject(project).withPreferredServer(languageServerDefinition).excludeInactive()
+						.collectAll((wrapper, server) -> {
+							if (languageServerDefinition.equals(wrapper.serverDefinition) && notifiedServers.add(server)) {
+								server.getWorkspaceService().didChangeConfiguration(params);
+							}
+							return CompletableFuture.completedFuture(null);
+						});
+			}
+
+			// check per-doc LS
+			for (final IWorkbenchWindow win : PlatformUI.getWorkbench().getWorkbenchWindows()) {
+				for (IWorkbenchPage page : win.getPages()) {
+					for (IEditorReference ref : page.getEditorReferences()) {
+						IEditorPart editor = ref.getEditor(false); // do not restore unopened editors
+						if (editor == null)
+							continue;
+
+						IDocument doc = LSPEclipseUtils.getDocument(editor.getEditorInput());
+						if (doc == null)
+							continue;
+
+						LanguageServers.forDocument(doc).withPreferredServer(languageServerDefinition)
+								.collectAll((wrapper, server) -> {
+									if (languageServerDefinition.equals(wrapper.serverDefinition) && notifiedServers.add(server)) {
+										server.getWorkspaceService().didChangeConfiguration(params);
+									}
+									return CompletableFuture.completedFuture(null);
+								});
+					}
+				}
+			}
 		}
 	}