fix(xml-catalog): preserve http/https URIs in system catalog #1957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WWD discarded XML catalog entries that were not file or jar URIs, omitting remote schemas contributed via WTP and triggering startup warnings. Accept http/https in XMLCatalogs.isSchemeSupportedInCatalog so LemMinX can resolve these remote schemas.
Member
Author
|
@mickaelistria when reviewing best ignore whitespace changes as the test project is configured for tabs but the file had spaces for indentation: https://github.com/eclipse-wildwebdeveloper/wildwebdeveloper/pull/1957/files?w=1 |
mickaelistria
merged commit c7a8e76
into
eclipse-wildwebdeveloper:master
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WWD discarded XML catalog entries that were not file or jar URIs, omitting remote schemas contributed via WTP and triggering startup warnings. Accept http/https in XMLCatalogs.isSchemeSupportedInCatalog so LemMinX can resolve these remote schemas.
This PR fixes #1892