Feature Request - Code Folding - Include closing } in fold

[nickfleming]

When folding a section it does not include the closing } so a fold ends up being 2 lines instead of 1

PHP joins it into one line (showing the parent closing on the unindented next line):

[mickaelistria]

Can you please share a textual version of a file that isn't folded correctly? Is it json, javascript, ... ?

[nickfleming]

Sure these are 2 different but similar styles,

Example 1:

Ext.define('Demo.view.main.ViewportToolbar', {
	extend: 'Ext.toolbar.Toolbar',
	xtype: 'viewporttoolbar',
	requires: [
		'Demo.store.Test'
	],
	controller: 'mainviewport',
	height: 64,
	itemId: 'headerBar',
	viewModel: {},
	items: [
		{
			xtype: 'tbspacer',
			width: 3
		},{
			reference: 'logo',
			itemId: 'header'
		}
	],
	listeners:{
		render: 'onToolbarRender'
	}
});

Example 2:

Ext.define('Demo.view.main.CustomRowWidget', {
	alias: 'plugin.customrowwidget',
	extend: 'Ext.grid.plugin.RowWidget',
	isCollapsed: function(rowIdx){
		var me = this, rowNode = me.view.getNode(rowIdx), row = Ext.fly(rowNode, '_rowExpander');
		return row.hasCls(me.rowCollapsedCls)
	},
	collapse: function(rowIdx){
		if(this.isCollapsed(rowIdx) == false){
			this.toggleRow(rowIdx, this.grid.getStore().getAt(rowIdx));
		}
	}
});

[mickaelistria]

At the moment, the language server that's used for JavaScript/TypeScript is currently able to fold full lines, and LSP4E also assumes those are full lines.
The LSP specification now says that folding can now be an arbitrary text range, so the language server and Eclipse LSP4E client should both be updated to have this feature workable in the IDE; then the language server would need to take a decision about the best format of folding (as it's not really consensual ;)

[sebthom]

What I find a bit odd is that for arrays the closing ] is folded but for objects/maps the closing } is not.