An IP Team Review request is created:

• -/-/vuejs/language-features-subset/v2.2.8

@sebthom the folder language-configurations/vue/ in the PR doesn't add any new language configurations while the existing ones [in master] don't seem to be the same as in https://github.com/vuejs/language-tools/tree/v2.2.8/extensions/vscode/languages .

Could you please check if these configurations need to be added to the PR?
Also, if you can, could you please take a look at the Vue test failure:

Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 53.42 s <<< FAILURE! -- in org.eclipse.wildwebdeveloper.tests.TestVue
org.eclipse.wildwebdeveloper.tests.TestVue.testVueTemplate -- Time elapsed: 7.771 s
org.eclipse.wildwebdeveloper.tests.TestVue.testVueApp -- Time elapsed: 30.30 s <<< FAILURE!
org.opentest4j.AssertionFailedError: Diagnostic not published in standalone component file ==> expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:214)
	at org.eclipse.wildwebdeveloper.tests.TestVue.testVueApp(TestVue.java:93)

@sebthom the folder language-configurations/vue/ in the PR doesn't add any new language configurations while the existing ones [in master] don't seem to be the same as in vuejs/language-tools@v2.2.8/extensions/vscode/languages .

Could you please check if these configurations need to be added to the PR?

@vrubezhny I don't understand what you mean. I just verified it again, all three locations contain the same language configuration files last modified two years ago.

• https://github.com/eclipse-wildwebdeveloper/wildwebdeveloper/tree/master/org.eclipse.wildwebdeveloper/language-configurations/vue
• https://github.com/vuejs/language-tools/tree/master/extensions/vscode/languages
• https://github.com/vuejs/language-tools/tree/v2.2.8/extensions/vscode/languages

The only thing I added as part of this PR is the missing license file and I updated the readme to point to a tag instead of master so that we know which version actually was copied.

Could you please check if these configurations need to be added to the PR? Also, if you can, could you please take a look at the Vue test failure:

Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 53.42 s <<< FAILURE! -- in org.eclipse.wildwebdeveloper.tests.TestVue
org.eclipse.wildwebdeveloper.tests.TestVue.testVueTemplate -- Time elapsed: 7.771 s
org.eclipse.wildwebdeveloper.tests.TestVue.testVueApp -- Time elapsed: 30.30 s <<< FAILURE!
org.opentest4j.AssertionFailedError: Diagnostic not published in standalone component file ==> expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:214)
	at org.eclipse.wildwebdeveloper.tests.TestVue.testVueApp(TestVue.java:93)

@vrubezhny the test failure is about the Vue language server not returning an expected annotation with 30secs for whatever reason. I cannot reproduce this locally nor on GitHub Actions, also it is not related to the textmate language files updated by this PR which are only used by TM4E for syntax highlighting and not by the language server. So it is either an infrastructure problem on Jenkins (e.g. the LS cannot start) or the test itself is flaky.

TestVue/testVueApp test failure doesn't look like related as it repeatedly appears in different, not related PRs