Disable BurningWave initialization by default #1305

BurningWave is using Unsafe to break the module system introduced with
Java 9, in order to allow WindowBuilder to access the internal Swing
fields and methods.

The implementation has already been adapted in the past so that this
dependency can be disabled, by setting the "wbp.burningwave.enabled"
system property to "false". But for the sake of backwards compatibility,
this property was initialized with "true".

With this change, this property now needs to be explicitly enabled.

Closes #1305

Author: ptziegler

.github/workflows/maven.yaml

@@ -23,11 +23,11 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, windows-latest]
-        java: [ 21, 24 ]
+        java: [ 21, 25 ]
         include:
           - java: 21
             target: 2024-06
-          - java: 24
+          - java: 25
             target: master
     runs-on: ${{ matrix.os }}   
     name: OS ${{ matrix.os }} Java ${{ matrix.java }} ${{ matrix.target }} compile

org.eclipse.wb.core/src/org/eclipse/wb/internal/core/EnvironmentUtils.java

@@ -232,6 +232,6 @@ public static boolean isGefPalette() {
 	private static final String WBP_BURNINGWAVE = "wbp.burningwave.enabled";
 
 	public static boolean isBurningWaveEnabled() {
-		return Boolean.valueOf(System.getProperty(WBP_BURNINGWAVE, Boolean.TRUE.toString()));
+		return Boolean.valueOf(System.getProperty(WBP_BURNINGWAVE, Boolean.FALSE.toString()));
 	}
 }

org.eclipse.wb.doc.user/html-src/whatsnew/v122.asciidoc

@@ -4,6 +4,19 @@ endif::[]
 
 = What's New - v1.22.0
 
+== General
+
+- Integrity by default
+
+WindowBuilder uses BurningWave to access the internal fields of the Swing
+components. In previous versions, this functionality was enabled by default
+but could be disabled by setting the `wbp.burningwave.enabled` system property
+to `false`. This property is now disabled by default and needs to be
+explicitly enabled.
+
+Users are encouraged to explicitly open the required modules using e.g.
+`--add-opens java.desktop/javax.swing=ALL-UNNAMED`.
+
 == Swing
 
 - Deprecated support for Applet/JApplet

org.eclipse.wb.tests/pom.xml

@@ -22,7 +22,7 @@
   <packaging>eclipse-test-plugin</packaging>
 
 	<properties>
-		<uitest.vmparams>-Dwbp.burningwave.enabled=false -Dorg.eclipse.swtbot.search.timeout=60000</uitest.vmparams>
+		<uitest.vmparams>-Dorg.eclipse.swtbot.search.timeout=60000</uitest.vmparams>
 	</properties>
 
 	<profiles>