Fix: Error when trying to delete selected tab item

The selection is not cleared when a tab item has been deleted. When
updating the widget, we then run into an unhandled exception because the
item we try to select no longer exists.

Author: ptziegler

org.eclipse.wb.rcp/src/org/eclipse/wb/internal/rcp/model/widgets/AbstractTabItemInfo.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2011 Google, Inc.
+ * Copyright (c) 2011, 2023 Google, Inc.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
@@ -75,6 +75,7 @@ public void selecting(ObjectInfo object, boolean[] refreshFlag) throws Exception
 			@Override
 			public void before(ObjectInfo parent, ObjectInfo child) throws Exception {
 				if (child == m_this) {
+					getFolder().m_selectedItem = null;
 					ControlInfo ourControl = getControl();
 					if (ourControl != null) {
 						ourControl.delete();

org.eclipse.wb.tests/src/org/eclipse/wb/tests/designer/rcp/model/widgets/CTabFolderTest.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2011 Google, Inc.
+ * Copyright (c) 2011, 2023 Google, Inc.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
@@ -252,6 +252,35 @@ public void test_selecting() throws Exception {
 		}
 	}
 
+	/**
+	 * Test whether the selection is removed when the tab item is deleted.
+	 *
+	 * @see <a href=
+	 *      "https://github.com/eclipse-windowbuilder/windowbuilder/issues/556">here</a>
+	 */
+	@Test
+	public void test_deleteSelectedTabItem() throws Exception {
+		CompositeInfo shell = parseComposite(
+				"public class Test extends Shell {",
+				"  public Test() {",
+				"    setLayout(new FillLayout());",
+				"    CTabFolder tabFolder = new CTabFolder(this, SWT.NONE);",
+				"    CTabItem item_1 = new CTabItem(tabFolder, SWT.NONE);",
+				"    CTabItem item_2 = new CTabItem(tabFolder, SWT.NONE);",
+				"  }",
+				"}");
+		shell.refresh();
+		CTabFolderInfo tabFolder = (CTabFolderInfo) shell.getChildrenControls().get(0);
+		CTabItemInfo item_1 = tabFolder.getItems2().get(0);
+		CTabItemInfo item_2 = tabFolder.getItems2().get(1);
+
+		item_2.doSelect();
+		assertEquals(tabFolder.getSelectedItem(), item_2);
+
+		item_2.delete();
+		assertEquals(tabFolder.getSelectedItem(), item_1);
+	}
+
 	/**
 	 * We should show on design canvas only {@link ControlInfo}'s of expanded {@link CTabItemInfo}'s.
 	 */

org.eclipse.wb.tests/src/org/eclipse/wb/tests/designer/rcp/model/widgets/TabFolderTest.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2011 Google, Inc.
+ * Copyright (c) 2011, 2023 Google, Inc.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
@@ -256,6 +256,35 @@ public void test_selecting() throws Exception {
 		}
 	}
 
+	/**
+	 * Test whether the selection is removed when the tab item is deleted.
+	 *
+	 * @see <a href=
+	 *      "https://github.com/eclipse-windowbuilder/windowbuilder/issues/556">here</a>
+	 */
+	@Test
+	public void test_deleteSelectedTabItem() throws Exception {
+		CompositeInfo shell = parseComposite(
+				"public class Test extends Shell {",
+				"  public Test() {",
+				"    setLayout(new FillLayout());",
+				"    TabFolder tabFolder = new TabFolder(this, SWT.NONE);",
+				"    TabItem item_1 = new TabItem(tabFolder, SWT.NONE);",
+				"    TabItem item_2 = new TabItem(tabFolder, SWT.NONE);",
+				"  }",
+				"}");
+		shell.refresh();
+		TabFolderInfo tabFolder = (TabFolderInfo) shell.getChildrenControls().get(0);
+		TabItemInfo item_1 = tabFolder.getItems2().get(0);
+		TabItemInfo item_2 = tabFolder.getItems2().get(1);
+
+		item_2.doSelect();
+		assertEquals(tabFolder.getSelectedItem(), item_2);
+
+		item_2.delete();
+		assertEquals(tabFolder.getSelectedItem(), item_1);
+	}
+
 	/**
 	 * We should show on design canvas only {@link ControlInfo}'s of expanded {@link TabItemInfo}'s.
 	 */