Make sure rustup is updated on the CI (and support 1.87 :) ) (#1948)

* Update ci.yml

* Fix clippy errors

* more clippy

* ignore extremely large error for config deserializer

* more clippy fixes

Author: yellowhatter

.github/workflows/ci.yml

@@ -90,6 +90,9 @@ jobs:
       - name: Update Stable Rust toolchain
         run: rustup update stable
 
+      - name: Make sure necessary tools are installed
+        run: rustup component add clippy rustfmt
+
       - name: Setup rust-cache
         uses: Swatinem/rust-cache@v2
         with:

commons/zenoh-buffers/src/zbuf.rs

@@ -407,8 +407,8 @@ impl io::Seek for ZBufReader<'_> {
             .take(self.cursor.slice)
             .fold(0, |acc, s| acc + s.len())
             + self.cursor.byte;
-        let current_pos = i64::try_from(current_pos)
-            .map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, e.to_string()))?;
+        let current_pos =
+            i64::try_from(current_pos).map_err(|e| std::io::Error::other(e.to_string()))?;
 
         let offset = match pos {
             std::io::SeekFrom::Start(s) => i64::try_from(s).unwrap_or(i64::MAX) - current_pos,

commons/zenoh-macros/src/lib.rs

@@ -60,6 +60,7 @@ pub fn rustc_version_release(_tokens: TokenStream) -> TokenStream {
 }
 
 /// An enumeration of items which can be annotated with `#[zenoh_macros::unstable_doc]`, #[zenoh_macros::unstable]`, `#[zenoh_macros::internal]`
+#[allow(clippy::large_enum_variant)]
 enum AnnotableItem {
     /// Wrapper around [`syn::Item`].
     Item(Item),

commons/zenoh-sync/src/condition.rs

@@ -23,18 +23,11 @@ pub type ConditionWaiter = Pin<Box<EventListener>>;
 /// not be race condition on [notify_one](Condition::notify_one) or
 /// [notify_all](Condition::notify_all).
 ///
+#[derive(Default)]
 pub struct Condition {
     event: Event,
 }
 
-impl Default for Condition {
-    fn default() -> Condition {
-        Condition {
-            event: Event::new(),
-        }
-    }
-}
-
 impl Condition {
     /// Creates a new condition variable with a given capacity.
     /// The capacity indicates the maximum number of tasks that

commons/zenoh-util/tests/zresult.rs

@@ -45,7 +45,7 @@ fn error_with_source() {
         panic!();
     }
 
-    let ioerr = std::io::Error::new(std::io::ErrorKind::Other, "IOERR");
+    let ioerr = std::io::Error::other("IOERR");
     let e = zerror!( ioerr =>"ERR2");
     let s = e.to_string();
     println!("{e}");

io/zenoh-links/zenoh-link-quic/src/unicast.rs

@@ -289,9 +289,8 @@ impl LinkManagerUnicastTrait for LinkManagerUnicastQuic {
 
         let mut quic_endpoint = {
             // create the Endpoint with this socket
-            let runtime = quinn::default_runtime().ok_or_else(|| {
-                std::io::Error::new(std::io::ErrorKind::Other, "no async runtime found")
-            })?;
+            let runtime = quinn::default_runtime()
+                .ok_or_else(|| std::io::Error::other("no async runtime found"))?;
             ZResult::Ok(quinn::Endpoint::new_with_abstract_socket(
                 EndpointConfig::default(),
                 None,
@@ -410,9 +409,8 @@ impl LinkManagerUnicastTrait for LinkManagerUnicastQuic {
                 zenoh_util::net::set_bind_to_device_udp_socket(&socket, iface)?;
 
                 // create the Endpoint with this socket
-                let runtime = quinn::default_runtime().ok_or_else(|| {
-                    std::io::Error::new(std::io::ErrorKind::Other, "no async runtime found")
-                })?;
+                let runtime = quinn::default_runtime()
+                    .ok_or_else(|| std::io::Error::other("no async runtime found"))?;
                 ZResult::Ok(quinn::Endpoint::new_with_abstract_socket(
                     EndpointConfig::default(),
                     Some(server_config),

zenoh/src/api/config.rs

@@ -130,6 +130,8 @@ impl Config {
     // REVIEW(fuzzypixelz): the error variant of the Result is a Result because this does
     // deserialization AND validation.
     #[zenoh_macros::unstable]
+    // TODO(yellowhatter): clippy says that Error here is extremely large (1k)
+    #[allow(clippy::result_large_err)]
     pub fn from_deserializer<'d, D: serde::Deserializer<'d>>(
         d: D,
     ) -> Result<Self, Result<Self, D::Error>>

zenoh/src/net/runtime/orchestrator.rs

@@ -1141,7 +1141,7 @@ impl Runtime {
         tracing::debug!("Waiting for UDP datagram...");
         loop {
             let (n, peer) = mcast_socket.recv_from(&mut buf).await.unwrap();
-            if local_addrs.iter().any(|addr| *addr == peer) {
+            if local_addrs.contains(&peer) {
                 tracing::trace!("Ignore UDP datagram from own socket");
                 continue;
             }