Adding forms for affordances does not work

[danielpeintner]

Clicking the "add" button doesn't do anything and fires some errors on the console

I used the following simple TD and wanted to change the status property

{
    "@context": "https://www.w3.org/ns/wot-next/td",
    "id": "urn:uuid:0804d572-cce8-422a-bb7c-4412fcd56f06",
    "title": "MyLampThing",
    "securityDefinitions": {
        "basic_sc": {"scheme": "basic", "in": "header"}
    },
    "security": "basic_sc",
    "properties": {
        "status": {
            "type": "string",
            "forms": [{"href": "https://mylamp.example.com/status"}]
        }
    },
    "actions": {
        "toggle": {
            "forms": [{"href": "https://mylamp.example.com/toggle"}]
        }
    },
    "events": {
        "overheating": {
            "data": {"type": "string"},
            "forms": [{
                "href": "https://mylamp.example.com/oh",
                "subprotocol": "longpoll"
            }]
        }
    }
}

[egekorkan]

Oh that used to work for sure! We must have broken something and don't have "end to end tests" for these. Thanks :)

[TejInaco]

Thanks, @danielpeintner, for opening this issue. I just need confirmation on one point: based on the screenshot, is the expected output after using “Add Property Form” on status the following?

"properties": {
        "status": {
            "type": "string",
            "forms": [{"href": "https://mylamp.example.com/statusX"}]
        }
    }, 

Or:

"status": {
            "type": "string",
            "forms": [
                   {
                      "href": "https://mylamp.example.com/status"
                    },
                    {
                    "op": [
                             "readproperty"
                      ],
                      "href": "https://mylamp.example.com/statusX"
                     }
             ]
        }

In this case, the user wants to edit the href value of an existing form, which is a different use case. Currently, changing href fails because the form object does not exist in the expected structure. To address this, an edit functionality for existing forms should be introduced @egekorkan . And as well as improve the distinction between different actions.

[danielpeintner]

@TejInaco with "add property form" I expect to get another form entry to be added (I don't expect to edit an existing form entry).

Hence, the last example you gave.

[TejInaco]

Thanks @danielpeintner for the confirmation. The fix will be available soon.