Apply suggestions from code review

nascs · RadxaYuntian · web-flow · commit 38d617cbe187 · 2024-03-07T10:53:58.000+08:00
Co-authored-by: ZHANG Yuntian &lt;yt@radxa.com&gt;
diff --git a/include/gpio/gpio_chardev.h b/include/gpio/gpio_chardev.h
@@ -48,7 +48,7 @@ mraa_boolean_t mraa_is_gpio_line_open_drain(mraa_gpiod_line_info *linfo);
 mraa_boolean_t mraa_is_gpio_line_open_source(mraa_gpiod_line_info *linfo);
 mraa_boolean_t mraa_is_gpio_line_bias_pull_up(mraa_gpiod_line_info *linfo);
 mraa_boolean_t mraa_is_gpio_line_bias_pull_down(mraa_gpiod_line_info *linfo);
-mraa_boolean_t mraa_is_gpio_line_disable(mraa_gpiod_line_info *linfo);
+mraa_boolean_t mraa_is_gpio_line_bias_disable(mraa_gpiod_line_info *linfo);
 
 int mraa_get_number_of_gpio_chips();
 int mraa_get_chip_infos(mraa_gpiod_chip_info*** cinfos);
diff --git a/src/gpio/gpio.c b/src/gpio/gpio.c
@@ -1162,9 +1162,6 @@ mraa_gpio_mode(mraa_gpio_context dev, mraa_gpio_mode_t mode)
             case MRAA_GPIO_PULLDOWN:
                 length = snprintf(bu, sizeof(bu), "pulldown");
                 break;
-            case MRAA_GPIO_DISABLE:
-                length = snprintf(bu, sizeof(bu), "disable");
-                break;
             case MRAA_GPIO_HIZ:
                 length = snprintf(bu, sizeof(bu), "hiz");
                 break;
diff --git a/src/gpio/gpio_chardev.c b/src/gpio/gpio_chardev.c
@@ -442,7 +442,7 @@ mraa_is_gpio_line_bias_pull_down(mraa_gpiod_line_info* linfo)
 }
 
 mraa_boolean_t
-mraa_is_gpio_line_disable(mraa_gpiod_line_info* linfo)
+mraa_is_gpio_line_bias_disable(mraa_gpiod_line_info* linfo)
 {
     return (linfo->flags & GPIOLINE_FLAG_BIAS_DISABLE);
 }

Original file line number	Diff line number	Diff line change
`@@ -442,7 +442,7 @@ mraa_is_gpio_line_bias_pull_down(mraa_gpiod_line_info* linfo)`
`442`	`442`	`}`
`443`	`443`
`444`	`444`	`mraa_boolean_t`
`445`		`-mraa_is_gpio_line_disable(mraa_gpiod_line_info* linfo)`
	`445`	`+mraa_is_gpio_line_bias_disable(mraa_gpiod_line_info* linfo)`
`446`	`446`	`{`
`447`	`447`	`return (linfo->flags & GPIOLINE_FLAG_BIAS_DISABLE);`
`448`	`448`	`}`