Skip to content

Commit c20b441

Browse files
authored
Merge pull request #1172 from amvanbaren/issue-1171
Fix CVE-2025-22228
2 parents 210825c + d56e3a6 commit c20b441

File tree

5 files changed

+7
-6
lines changed

5 files changed

+7
-6
lines changed

server/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ plugins {
1111
id 'jacoco'
1212
id 'nu.studer.jooq' version '8.2.1'
1313
id 'de.undercouch.download' version '5.4.0'
14-
id 'org.springframework.boot' version '3.2.4'
14+
id 'org.springframework.boot' version '3.3.10'
1515
id 'io.spring.dependency-management' version '1.1.0'
1616
id 'io.gatling.gradle' version '3.9.5'
1717
id 'java'

server/src/main/java/org/eclipse/openvsx/search/DatabaseSearchService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public SearchHits<ExtensionSearch> search(ISearchService.Options options) {
6262

6363
// no extensions in the database
6464
if (matchingExtensions.isEmpty()) {
65-
return new SearchHitsImpl<>(0,TotalHitsRelation.OFF, 0f, null, null, Collections.emptyList(), null, null);
65+
return new SearchHitsImpl<>(0,TotalHitsRelation.OFF, 0f, null, null, Collections.emptyList(), null, null, null);
6666
}
6767

6868
// exlude namespaces
@@ -148,7 +148,7 @@ public SearchHits<ExtensionSearch> search(ISearchService.Options options) {
148148
searchHits = sortedExtensions.stream().map(extensionSearch -> new SearchHit<>(null, null, null, 0.0f, null, null, null, null, null, null, extensionSearch)).collect(Collectors.toList());
149149
}
150150

151-
return new SearchHitsImpl<>(totalHits, TotalHitsRelation.OFF, 0f, null, null, searchHits, null, null);
151+
return new SearchHitsImpl<>(totalHits, TotalHitsRelation.OFF, 0f, null, null, searchHits, null, null, null);
152152
}
153153

154154
@Override

server/src/main/java/org/eclipse/openvsx/search/ElasticSearchService.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ public void removeSearchEntry(Extension extension) {
248248
public SearchHits<ExtensionSearch> search(Options options) {
249249
var resultWindow = options.requestedOffset() + options.requestedSize();
250250
if(resultWindow > getMaxResultWindow()) {
251-
return new SearchHitsImpl<>(0, TotalHitsRelation.OFF, 0f, null, null, Collections.emptyList(), null, null);
251+
return new SearchHitsImpl<>(0, TotalHitsRelation.OFF, 0f, null, null, Collections.emptyList(), null, null, null);
252252
}
253253

254254
var queryBuilder = new NativeQueryBuilder();
@@ -294,6 +294,7 @@ public SearchHits<ExtensionSearch> search(Options options) {
294294
null,
295295
searchHits,
296296
null,
297+
null,
297298
null
298299
);
299300
} else {

server/src/test/java/org/eclipse/openvsx/RegistryAPITest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2184,7 +2184,7 @@ private List<ExtensionVersion> mockSearch() {
21842184
var entry1 = new ExtensionSearch();
21852185
entry1.setId(1);
21862186
var searchHit = new SearchHit<>("0", "1", null, 1.0f, null, null, null, null, null, null, entry1);
2187-
var searchHits = new SearchHitsImpl<>(1, TotalHitsRelation.EQUAL_TO, 1.0f, "1", null, List.of(searchHit), null, null);
2187+
var searchHits = new SearchHitsImpl<>(1, TotalHitsRelation.EQUAL_TO, 1.0f, "1", null, List.of(searchHit), null, null, null);
21882188
Mockito.when(search.isEnabled())
21892189
.thenReturn(true);
21902190
var searchOptions = new ISearchService.Options("foo", null, null, 10, 0, "desc", "relevance", false, null);

server/src/test/java/org/eclipse/openvsx/adapter/VSCodeAPITest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -633,7 +633,7 @@ private Extension mockSearch(String targetPlatform, String namespaceName, boolea
633633
? Collections.singletonList(new SearchHit<>("0", "1", null, 1.0f, null, null, null, null, null, null, entry1))
634634
: Collections.emptyList();
635635
var searchHits = new SearchHitsImpl<>(searchResults.size(), TotalHitsRelation.EQUAL_TO, 1.0f, "1", null,
636-
searchResults, null, null);
636+
searchResults, null, null, null);
637637

638638
Mockito.when(integrityService.isEnabled())
639639
.thenReturn(true);

0 commit comments

Comments
 (0)