Use format specifiers

Format specifiers should be used instead of string concatenation.

Author: amvanbaren

server/src/main/java/org/eclipse/openvsx/eclipse/EclipseService.java

@@ -274,7 +274,7 @@ private EclipseProfile parseEclipseProfile(ResponseEntity<String> response) {
         try {
             if (json.startsWith("[\"")) {
                 var error = objectMapper.readValue(json, TYPE_LIST_STRING);
-                logger.error("Profile request failed:\n" + json);
+                logger.error("Profile request failed:\n{}", json);
                 throw new ErrorResultException("Request to the Eclipse Foundation server failed: " + error,
                         HttpStatus.INTERNAL_SERVER_ERROR);
             } else if (json.startsWith("[")) {
@@ -394,7 +394,7 @@ private PublisherAgreement parseAgreementResponse(ResponseEntity<String> respons
             PublisherAgreementResponse agreementResponse;
             if (json.startsWith("[\"")) {
                 var error = objectMapper.readValue(json, TYPE_LIST_STRING);
-                logger.error("Publisher agreement request failed:\n" + json);
+                logger.error("Publisher agreement request failed:\n{}", json);
                 throw new ErrorResultException("Request to the Eclipse Foundation server failed: " + error,
                         HttpStatus.INTERNAL_SERVER_ERROR);
             } else if (json.startsWith("[")) {

server/src/main/java/org/eclipse/openvsx/eclipse/PublisherComplianceChecker.java

@@ -104,7 +104,7 @@ private void deactivateExtensions(List<PersonalAccessToken> accessTokens) {
                 entityManager.merge(version);
                 var extension = version.getExtension();
                 affectedExtensions.add(extension);
-                logger.info("Deactivated: " + accessToken.getUser().getLoginName() + " - " + NamingUtil.toLogFormat(version));
+                logger.info("Deactivated: {} - {}", accessToken.getUser().getLoginName(), NamingUtil.toLogFormat(version));
             }
         }
 

server/src/main/java/org/eclipse/openvsx/migration/OrphanNamespaceMigration.java

@@ -72,10 +72,10 @@ public void fixOrphanNamespaces() {
         });
 
         if (count[0] > 0)
-            logger.info("Deleted " + count[0] + " namespaces that were orphaned and empty.");
+            logger.info("Deleted {} namespaces that were orphaned and empty.", count[0]);
         if (count[1] > 0)
-            logger.info("Assigned explicit members to " + count[1] + " orphaned namespaces.");
+            logger.info("Assigned explicit members to {} orphaned namespaces.", count[1]);
         if (count[2] > 0)
-            logger.info("Found " + count[2] + " orphaned namespaces that could not be fixed.");
+            logger.info("Found {} orphaned namespaces that could not be fixed.", count[2]);
     }
 }

server/src/main/java/org/eclipse/openvsx/search/ElasticSearchService.java

@@ -100,7 +100,7 @@ public void initSearchIndex(ApplicationStartedEvent event) {
         stopWatch.start();
         updateSearchIndex(clearOnStart);
         stopWatch.stop();
-        logger.info("Initialized search index in " + stopWatch.getTotalTimeMillis() + " ms");
+        logger.info("Initialized search index in {} ms", stopWatch.getTotalTimeMillis());
     }
 
     /**
@@ -118,7 +118,7 @@ public void updateSearchIndex() {
         stopWatch.start();
         updateSearchIndex(false);
         stopWatch.stop();
-        logger.info("Updated search index in " + stopWatch.getTotalTimeMillis() + " ms");
+        logger.info("Updated search index in {} ms", stopWatch.getTotalTimeMillis());
     }
 
     /**

server/src/main/java/org/eclipse/openvsx/storage/StorageMigration.java

@@ -84,8 +84,7 @@ public void findResources(ApplicationStartedEvent event) {
         if (!resourceQueue.isEmpty()) {
             for (var i = 0; i < migrations.size(); i++) {
                 if (migrationCount[i] > 0) {
-                    logger.info("Migrating " + migrationCount[i] + " resources from "
-                            + migrations.get(i) + " to " + storageType + ".");
+                    logger.info("Migrating {} resources from {} to {}.", migrationCount[i], migrations.get(i), storageType);
                 }
             }
             var duration = Duration.of(migrationDelay, ChronoUnit.MILLIS);
@@ -114,7 +113,7 @@ public void migrateResources() {
 
         var remainingCount = resourceQueue.size();
         if (remainingCount > 0 && remainingCount % 1000 == 0) {
-            logger.info("Remaining resources to migrate: " + remainingCount);
+            logger.info("Remaining resources to migrate: {}", remainingCount);
         }
     }
 }