Skip to content

Commit dde96a5

Browse files
authored
Merge pull request #1105 from amvanbaren/trace-unpkg-asset
Observe /vscode/unpkg and /vscode/asset requests
2 parents 5bae340 + 6bfab8b commit dde96a5

File tree

5 files changed

+11
-1
lines changed

5 files changed

+11
-1
lines changed

server/src/main/java/org/eclipse/openvsx/adapter/LocalVSCodeService.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
package org.eclipse.openvsx.adapter;
1111

1212
import com.google.common.collect.Lists;
13+
import io.micrometer.observation.annotation.Observed;
1314
import org.apache.commons.lang3.StringUtils;
1415
import org.eclipse.openvsx.cache.CacheService;
1516
import org.eclipse.openvsx.entities.Extension;
@@ -273,6 +274,7 @@ private String getSortOrder(int sortOrder) {
273274
}
274275
}
275276

277+
@Observed
276278
@Override
277279
public ResponseEntity<StreamingResponseBody> getAsset(
278280
String namespace, String extensionName, String version, String assetType, String targetPlatform,
@@ -392,6 +394,7 @@ public String download(String namespaceName, String extensionName, String versio
392394
}
393395
}
394396

397+
@Observed
395398
@Override
396399
public ResponseEntity<StreamingResponseBody> browse(String namespaceName, String extensionName, String version, String path) {
397400
if(BuiltInExtensionUtil.isBuiltIn(namespaceName)) {

server/src/main/java/org/eclipse/openvsx/adapter/VSCodeAPI.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
********************************************************************************/
1010
package org.eclipse.openvsx.adapter;
1111

12+
import io.micrometer.observation.annotation.Observed;
1213
import io.swagger.v3.oas.annotations.Operation;
1314
import io.swagger.v3.oas.annotations.Parameter;
1415
import io.swagger.v3.oas.annotations.headers.Header;
@@ -87,6 +88,7 @@ public ExtensionQueryResult extensionQuery(@RequestBody @Parameter(description =
8788
return extensionQueryRequestHandler.getResult(param, size, DEFAULT_PAGE_SIZE);
8889
}
8990

91+
@Observed
9092
@GetMapping("/vscode/asset/{namespaceName}/{extensionName}/{version}/{assetType}/**")
9193
@CrossOrigin
9294
@Operation(summary = "Access an extension asset")
@@ -258,6 +260,7 @@ public ModelAndView download(
258260
return new ModelAndView(null, HttpStatus.NOT_FOUND);
259261
}
260262

263+
@Observed
261264
@GetMapping("/vscode/unpkg/{namespaceName}/{extensionName}/{version}/**")
262265
@CrossOrigin
263266
@Operation(summary = "Browse an extension package")

server/src/main/java/org/eclipse/openvsx/adapter/WebResourceService.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
package org.eclipse.openvsx.adapter;
1111

1212
import com.fasterxml.jackson.databind.ObjectMapper;
13+
import io.micrometer.observation.annotation.Observed;
1314
import org.eclipse.openvsx.cache.CacheService;
1415
import org.eclipse.openvsx.cache.FilesCacheKeyGenerator;
1516
import org.eclipse.openvsx.entities.FileResource;
@@ -56,6 +57,7 @@ public WebResourceService(
5657
this.filesCacheKeyGenerator = filesCacheKeyGenerator;
5758
}
5859

60+
@Observed
5961
@Cacheable(value = CACHE_WEB_RESOURCE_FILES, keyGenerator = GENERATOR_FILES)
6062
public Path getWebResource(String namespace, String extension, String targetPlatform, String version, String name, boolean browse) {
6163
var download = repositories.findFileByType(namespace, extension, targetPlatform, version, FileResource.DOWNLOAD);

server/src/main/java/org/eclipse/openvsx/cache/CacheService.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
* ****************************************************************************** */
1010
package org.eclipse.openvsx.cache;
1111

12+
import io.micrometer.observation.annotation.Observed;
1213
import org.eclipse.openvsx.entities.*;
1314
import org.eclipse.openvsx.repositories.RepositoryService;
1415
import org.eclipse.openvsx.util.TargetPlatform;
@@ -176,6 +177,7 @@ public void evictExtensionFile(FileResource download) {
176177
cache.evict(filesCacheKeyGenerator.generate(download));
177178
}
178179

180+
@Observed
179181
public void evictWebResourceFile(String namespaceName, String extensionName, String targetPlatform, String version, String path) {
180182
var cache = cacheManager.getCache(CACHE_WEB_RESOURCE_FILES);
181183
if(cache == null) {

server/src/main/java/org/eclipse/openvsx/metrics/MetricsConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
@Configuration
2222
@Profile("!test")
2323
public class MetricsConfiguration {
24-
//@Bean
24+
@Bean
2525
public ObservedAspect observedAspect(ObservationRegistry observationRegistry) {
2626
return new ObservedAspect(observationRegistry, new RegistryObservationConvention());
2727
}

0 commit comments

Comments
 (0)