Prevent SIOOBE in JSHint#fixPosition

JSHint#fixPosition was missing a safeguard for the case that the error
position reported by JSHint exceeds the input string.

Fixes #34

Author: ralfstx

bundles/com.eclipsesource.jshint/src/com/eclipsesource/jshint/JSHint.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2012 EclipseSource.
+ * Copyright (c) 2012, 2013 EclipseSource.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
@@ -240,7 +240,8 @@ private int fixPosition( Text text, int line, int character ) {
     int offset = text.getLineOffset( line - 1 );
     int indentIndex = 0;
     int charIndex = 0;
-    while( indentIndex < character - 1 ) {
+    int maxIndex = Math.min( character, string.length() - offset ) - 1;
+    while( indentIndex < maxIndex ) {
       boolean isTab = string.charAt( offset + indentIndex ) == '\t';
       indentIndex += isTab ? indent : 1;
       charIndex++;

tests/com.eclipsesource.jshint.test/src/com/eclipsesource/jshint/JSHint_Test.java

@@ -267,6 +267,24 @@ public void errorWithUndefInConfig() {
     assertThat( problems.get( 0 ).getMessage(), containsString( "'v' is not defined" ) );
   }
 
+  @Test
+  public void errorAfterTabHasCorrectPosition() {
+    jsHint.configure( new Configuration().addOption( "undef", true ) );
+
+    jsHint.check( "var x = 1,\t# y = 2;", handler );
+
+    assertEquals( 11, problems.get( 0 ).getCharacter() );
+  }
+
+  @Test
+  public void errorAtEndDoesNotThrowException() {
+    jsHint.configure( new Configuration().addOption( "undef", true ) );
+
+    // Must not throw SIOOBE
+    // See https://github.com/eclipsesource/jshint-eclipse/issues/34
+    jsHint.check( "var x = 1;\t#", handler );
+  }
+
   private class TestHandler implements ProblemHandler {
 
     public void handleProblem( Problem problem ) {