Fix and revise tests, run more tests with all versions

In order to ensure that our assumptions hold true with all supported
versions of JSHint, we should run functional tests against all versions.

Author: ralfstx

com.eclipsesource.jshint.test/src/com/eclipsesource/jshint/JSHint_Compatibility_Test.java

@@ -23,6 +23,7 @@
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertTrue;
+import static org.junit.Assume.assumeTrue;
 
 
 @RunWith( value = Parameterized.class )
@@ -36,6 +37,7 @@ public class JSHint_Compatibility_Test {
   @Parameters
   public static Collection<Object[]> getParameters() {
     ArrayList<Object[]> parameters = new ArrayList<Object[]>();
+    parameters.add( new Object[] { "com/jslint/jslint-2012-02-03.js" } );
     parameters.add( new Object[] { "com/jshint/jshint-r03.js" } );
     parameters.add( new Object[] { "com/jshint/jshint-r04.js" } );
     parameters.add( new Object[] { "com/jshint/jshint-r05.js" } );
@@ -46,7 +48,6 @@ public static Collection<Object[]> getParameters() {
     parameters.add( new Object[] { "com/jshint/jshint-r10.js" } );
     parameters.add( new Object[] { "com/jshint/jshint-r11.js" } );
     parameters.add( new Object[] { "com/jshint/jshint-r12.js" } );
-    parameters.add( new Object[] { "com/jslint/jslint-2012-02-03.js" } );
     return parameters;
   }
 
@@ -63,33 +64,138 @@ public void setUp() throws IOException {
   }
 
   @Test
-  public void check_noProblemsIfValid() {
+  public void noProblemsForValidCode() {
     jsHint.check( "var a = 23;", handler );
 
     assertTrue( problems.isEmpty() );
   }
 
   @Test
-  public void check_problemLineIs_1_Relative() {
+  public void problemLineIs_1_Relative() {
     jsHint.check( "#", handler );
 
     assertEquals( 1, problems.get( 0 ).getLine() );
   }
 
   @Test
-  public void check_problemCharacterIs_0_Relative() {
+  public void problemCharacterIs_0_Relative() {
     jsHint.check( "#", handler );
 
     assertEquals( 0, problems.get( 0 ).getCharacter() );
   }
 
   @Test
-  public void check_problemMessageIsNotEmpty() {
+  public void cproblemMessageIsNotEmpty() {
     jsHint.check( "#", handler );
 
     assertTrue( problems.get( 0 ).getMessage().length() > 0 );
   }
 
+  @Test
+  public void undefinedVariable_withoutConfig_succeeds() {
+    jsHint.check( "foo = {};", handler );
+
+    // seems that the undef option is inverted in jslint
+    String expected = isJsLint() ? "1.0:'foo' was used before it was defined" : "";
+    assertEquals( expected, getAllProblems() );
+  }
+
+  @Test
+  public void undefinedVariable_withoutPredefInConfig_fails() {
+    jsHint.configure( new Configuration().addOption( "undef", true ) );
+
+    jsHint.check( "foo = {};", handler );
+
+    // seems that the undef option is inverted in jslint
+    String expected = isJsLint() ? "" : "1.0:'foo' is not defined";
+    assertEquals( expected, getAllProblems() );
+  }
+
+  @Test
+  public void undefinedVariable_withPredefInConfig_succeeds() {
+    jsHint.configure( new Configuration().addOption( "undef", true ).addPredefined( "foo", true ) );
+
+    jsHint.check( "foo = {};", handler );
+
+    assertEquals( "", getAllProblems() );
+  }
+
+  @Test
+  public void undefinedVariable_withReadOnlyPredefInConfig_fails() {
+    // FIXME [rst] See https://github.com/jshint/jshint/issues/665
+    assumeTrue( !isVersion( "r10" ) && !isVersion( "r11" ) && !isVersion( "r12" ) );
+    jsHint.configure( new Configuration().addOption( "undef", true ).addPredefined( "foo", false ) );
+
+    jsHint.check( "foo = {};", handler );
+
+    assertEquals( "1.0:Read only", getAllProblems() );
+  }
+
+  @Test
+  public void eqnull_withoutConfig() {
+    jsHint.check( "var x = 23 == null;", handler );
+
+    String expected = isJsLint() ? "Expected '===' and instead saw '=='"
+                                 : "Use '===' to compare with 'null'";
+    assertEquals( "1.11:" + expected, getAllProblems() );
+  }
+
+  @Test
+  public void eqnull_withEmptyConfig() {
+    jsHint.configure( new Configuration() );
+
+    jsHint.check( "var x = 23 == null;", handler );
+
+    String expected = isJsLint() ? "Expected '===' and instead saw '=='"
+                                   : "Use '===' to compare with 'null'";
+    assertEquals( "1.11:" + expected, getAllProblems() );
+  }
+
+  @Test
+  public void eqnull_withEqnullInConfig() {
+    // JSLint doesn't get this right
+    assumeTrue( !isJsLint() );
+    jsHint.configure( new Configuration().addOption( "eqnull", true ) );
+
+    jsHint.check( "var f = x == null ? null : x + 1;", handler );
+
+    assertEquals( "", getAllProblems() );
+  }
+
+  @Test
+  public void positionIsCorrect() {
+    jsHint.check( "var x = 23 == null;", handler );
+
+    assertEquals( "1.11", getPositionFromProblem( 0 ) );
+  }
+
+  @Test
+  public void positionIsCorrectWithLeadingSpace() {
+    assumeTrue( !isJsLint() );
+    jsHint.configure( new Configuration().addOption( "white", false ) );
+    jsHint.check( " var x = 23 == null;", handler );
+
+    assertEquals( "1.12", getPositionFromProblem( 0 ) );
+  }
+
+  @Test
+  public void positionIsCorrectWithLeadingTab() {
+    assumeTrue( !isJsLint() );
+    jsHint.configure( new Configuration().addOption( "white", false ) );
+    jsHint.check( "\tvar x = 23 == null;", handler );
+
+    assertEquals( "1.12", getPositionFromProblem( 0 ) );
+  }
+
+  @Test
+  public void positionIsCorrectWithMultipleTabs() {
+    assumeTrue( !isJsLint() );
+    jsHint.configure( new Configuration().addOption( "white", false ) );
+    jsHint.check( "\tvar x\t= 23 == null;", handler );
+
+    assertEquals( "1.12", getPositionFromProblem( 0 ) );
+  }
+
   private void loadJsHint() throws IOException {
     ClassLoader classLoader = getClass().getClassLoader();
     InputStream stream = classLoader.getResourceAsStream( jsHintResource );
@@ -100,6 +206,34 @@ private void loadJsHint() throws IOException {
     }
   }
 
+  private boolean isVersion( String version ) {
+    return jsHintResource.contains( version );
+  }
+
+  private boolean isJsLint() {
+    return jsHintResource.contains( "jslint" );
+  }
+
+  private String getPositionFromProblem( int n ) {
+    Problem problem = problems.get( n );
+    return problem.getLine() + "." + problem.getCharacter();
+  }
+
+  private String getAllProblems() {
+    StringBuilder builder = new StringBuilder();
+    for( Problem problem : problems ) {
+      if( builder.length() > 0 ) {
+        builder.append( ", " );
+      }
+      builder.append( problem.getLine() );
+      builder.append( '.' );
+      builder.append( problem.getCharacter() );
+      builder.append( ':' );
+      builder.append( problem.getMessage() );
+    }
+    return builder.toString();
+  }
+
   private class TestHandler implements ProblemHandler {
 
     public void handleProblem( Problem problem ) {