Handle exceptions caused by JSHint

So far, we only handled JavaScript errors, which are explicitly thrown
by JavaScript code. We did not handle exceptions that happen in the
JavaScript engine during the execution of JSHint.

We now handle the latter too and distinguish both types in the error
message to make the cause of the error more obvious.

Author: ralfstx

com.eclipsesource.jshint.test/src/com/eclipsesource/jshint/JSHint_Test.java

@@ -18,6 +18,8 @@
 
 import org.junit.Before;
 import org.junit.Test;
+import org.mozilla.javascript.EcmaError;
+import org.mozilla.javascript.JavaScriptException;
 
 import static org.hamcrest.Matchers.containsString;
 import static org.hamcrest.Matchers.startsWith;
@@ -216,8 +218,25 @@ public void checkWithJavaScriptException() throws Exception {
       fail();
     } catch( RuntimeException exception ) {
 
-      String expected = "JavaScript exception occured in JSHint check: ERROR";
+      String expected = "JavaScript exception thrown by JSHint: ERROR";
       assertThat( exception.getMessage(), startsWith( expected ) );
+      assertSame( JavaScriptException.class, exception.getCause().getClass() );
+    }
+  }
+
+  @Test
+  public void checkWithRhinoException() throws Exception {
+    JSHint jsHint = new JSHint();
+    jsHint.load( new ByteArrayInputStream( "JSHINT = function() { throw x[ 0 ]; };".getBytes() ) );
+
+    try {
+      jsHint.check( "var a = 1;", handler );
+      fail();
+    } catch( RuntimeException exception ) {
+
+      String expected = "JavaScript exception caused by JSHint: ReferenceError";
+      assertThat( exception.getMessage(), startsWith( expected ) );
+      assertSame( EcmaError.class, exception.getCause().getClass() );
     }
   }
 

com.eclipsesource.jshint/src/com/eclipsesource/jshint/JSHint.java

@@ -186,7 +186,10 @@ private boolean checkCode( Context context, String code ) {
       Object[] args = new Object[] { code, opts };
       return ( (Boolean)jshint.call( context, scope, null, args ) ).booleanValue();
     } catch( JavaScriptException exception ) {
-      String message = "JavaScript exception occured in JSHint check: " + exception.getMessage();
+      String message = "JavaScript exception thrown by JSHint: " + exception.getMessage();
+      throw new RuntimeException( message, exception );
+    } catch( RhinoException exception ) {
+      String message = "JavaScript exception caused by JSHint: " + exception.getMessage();
       throw new RuntimeException( message, exception );
     }
   }