Fix ESLint issues

Fix remaining ESLint issues with these exceptions that will be handled in a follow up
- import/no-named-as-default in vanilla-renderers, material-renderers
- no-prototype-builtins
- @typescript-eslint/no-explicit-any
- typescript-eslint/ban-types

Part of #1551

Author: lucas-koehler

packages/angular-material/src/controls/autocomplete.renderer.ts

@@ -22,7 +22,12 @@
   OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
   THE SOFTWARE.
 */
-import { ChangeDetectionStrategy, Component, Input } from '@angular/core';
+import {
+  ChangeDetectionStrategy,
+  Component,
+  Input,
+  OnInit,
+} from '@angular/core';
 import type { MatAutocompleteSelectedEvent } from '@angular/material/autocomplete';
 import { JsonFormsAngularService, JsonFormsControl } from '@jsonforms/angular';
 import {
@@ -96,7 +101,10 @@ import { map, startWith } from 'rxjs/operators';
   `,
   changeDetection: ChangeDetectionStrategy.OnPush,
 })
-export class AutocompleteControlRenderer extends JsonFormsControl {
+export class AutocompleteControlRenderer
+  extends JsonFormsControl
+  implements OnInit
+{
   @Input() options: string[];
   filteredOptions: Observable<string[]>;
   shouldFilter: boolean;

packages/angular-material/src/other/label.renderer.ts

@@ -22,7 +22,7 @@
   OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
   THE SOFTWARE.
 */
-import { Component } from '@angular/core';
+import { Component, OnDestroy, OnInit } from '@angular/core';
 import {
   JsonFormsAngularService,
   JsonFormsBaseRenderer,
@@ -42,7 +42,10 @@ import { Subscription } from 'rxjs';
   selector: 'LabelRenderer',
   template: ` <label class="mat-title" fxFlex> {{ label }} </label> `,
 })
-export class LabelRenderer extends JsonFormsBaseRenderer<LabelElement> {
+export class LabelRenderer
+  extends JsonFormsBaseRenderer<LabelElement>
+  implements OnDestroy, OnInit
+{
   label: string;
   visible: boolean;
 

packages/angular-material/src/other/master-detail/master.ts

@@ -28,6 +28,7 @@ import {
   ChangeDetectionStrategy,
   ChangeDetectorRef,
   Component,
+  OnInit,
 } from '@angular/core';
 import {
   JsonFormsAngularService,
@@ -146,7 +147,10 @@ export const removeSchemaKeywords = (path: string) => {
   ],
   changeDetection: ChangeDetectionStrategy.OnPush,
 })
-export class MasterListComponent extends JsonFormsArrayControl {
+export class MasterListComponent
+  extends JsonFormsArrayControl
+  implements OnInit
+{
   masterItems: any[];
   selectedItem: any;
   selectedItemIdx: number;

packages/angular-material/src/other/table.renderer.ts

@@ -23,7 +23,7 @@
   THE SOFTWARE.
 */
 import startCase from 'lodash/startCase';
-import { Component } from '@angular/core';
+import { Component, OnInit } from '@angular/core';
 import {
   JsonFormsAngularService,
   JsonFormsArrayControl,
@@ -137,7 +137,7 @@ import {
   `,
   styles: ['table {width: 100%;}', '.cdk-column-action { width: 15%}'],
 })
-export class TableRenderer extends JsonFormsArrayControl {
+export class TableRenderer extends JsonFormsArrayControl implements OnInit {
   detailUiSchema: UISchemaElement;
   displayedColumns: string[];
   items: ColumnDescription[];

packages/angular-material/test/autocomplete-control.spec.ts

@@ -233,7 +233,7 @@ describe('AutoComplete control Input Event Tests', () => {
     fixture = TestBed.createComponent(componentUT);
     component = fixture.componentInstance;
     zone = TestBed.inject(NgZone);
-    spyOn(zone, 'runOutsideAngular').and.callFake((fn: Function) => fn());
+    spyOn(zone, 'runOutsideAngular').and.callFake((fn: () => any) => fn());
     inputElement = fixture.debugElement.query(By.css('input')).nativeElement;
   });
 

packages/angular/src/abstract-control.ts

@@ -140,8 +140,7 @@ export abstract class JsonFormsAbstractControl<
     return this.error ? { error: this.error } : null;
   };
 
-  // @ts-ignore
-  mapAdditionalProps(props: Props) {
+  mapAdditionalProps(_props: Props) {
     // do nothing by default
   }
 

packages/angular/src/jsonforms-root.component.ts

@@ -24,6 +24,7 @@
 */
 import {
   Component,
+  DoCheck,
   EventEmitter,
   Input,
   OnChanges,
@@ -42,12 +43,15 @@ import {
 } from '@jsonforms/core';
 import Ajv, { ErrorObject } from 'ajv';
 import { JsonFormsAngularService, USE_STATE_VALUE } from './jsonforms.service';
+
+// TODO Can this be rewritten to not use DoCheck and OnChanges?
+/* eslint-disable @angular-eslint/no-conflicting-lifecycle */
 @Component({
   selector: 'jsonforms',
   template: '<jsonforms-outlet></jsonforms-outlet>',
   providers: [JsonFormsAngularService],
 })
-export class JsonForms implements OnChanges, OnInit {
+export class JsonForms implements DoCheck, OnChanges, OnInit {
   @Input() uischema: UISchemaElement;
   @Input() schema: JsonSchema;
   @Input() data: any;

packages/core/src/actions/actions.ts

@@ -32,33 +32,29 @@ import type { RankedTester } from '../testers';
 import type { UISchemaTester, ValidationMode } from '../reducers';
 import type { ErrorTranslator, Translator } from '../i18n';
 
-export const INIT: 'jsonforms/INIT' = 'jsonforms/INIT';
-export const UPDATE_CORE: 'jsonforms/UPDATE_CORE' = `jsonforms/UPDATE_CORE`;
-export const SET_AJV: 'jsonforms/SET_AJV' = 'jsonforms/SET_AJV';
-export const UPDATE_DATA: 'jsonforms/UPDATE' = 'jsonforms/UPDATE';
-export const UPDATE_ERRORS: 'jsonforms/UPDATE_ERRORS' =
-  'jsonforms/UPDATE_ERRORS';
-export const VALIDATE: 'jsonforms/VALIDATE' = 'jsonforms/VALIDATE';
-export const ADD_RENDERER: 'jsonforms/ADD_RENDERER' = 'jsonforms/ADD_RENDERER';
-export const REMOVE_RENDERER: 'jsonforms/REMOVE_RENDERER' =
-  'jsonforms/REMOVE_RENDERER';
-export const ADD_CELL: 'jsonforms/ADD_CELL' = 'jsonforms/ADD_CELL';
-export const REMOVE_CELL: 'jsonforms/REMOVE_CELL' = 'jsonforms/REMOVE_CELL';
-export const SET_CONFIG: 'jsonforms/SET_CONFIG' = 'jsonforms/SET_CONFIG';
-export const ADD_UI_SCHEMA: 'jsonforms/ADD_UI_SCHEMA' = `jsonforms/ADD_UI_SCHEMA`;
-export const REMOVE_UI_SCHEMA: 'jsonforms/REMOVE_UI_SCHEMA' = `jsonforms/REMOVE_UI_SCHEMA`;
-export const SET_SCHEMA: 'jsonforms/SET_SCHEMA' = `jsonforms/SET_SCHEMA`;
-export const SET_UISCHEMA: 'jsonforms/SET_UISCHEMA' = `jsonforms/SET_UISCHEMA`;
-export const SET_VALIDATION_MODE: 'jsonforms/SET_VALIDATION_MODE' =
-  'jsonforms/SET_VALIDATION_MODE';
-
-export const SET_LOCALE: 'jsonforms/SET_LOCALE' = `jsonforms/SET_LOCALE`;
-export const SET_TRANSLATOR: 'jsonforms/SET_TRANSLATOR' =
-  'jsonforms/SET_TRANSLATOR';
-export const UPDATE_I18N: 'jsonforms/UPDATE_I18N' = 'jsonforms/UPDATE_I18N';
-
-export const ADD_DEFAULT_DATA: 'jsonforms/ADD_DEFAULT_DATA' = `jsonforms/ADD_DEFAULT_DATA`;
-export const REMOVE_DEFAULT_DATA: 'jsonforms/REMOVE_DEFAULT_DATA' = `jsonforms/REMOVE_DEFAULT_DATA`;
+export const INIT = 'jsonforms/INIT' as const;
+export const UPDATE_CORE = 'jsonforms/UPDATE_CORE' as const;
+export const SET_AJV = 'jsonforms/SET_AJV' as const;
+export const UPDATE_DATA = 'jsonforms/UPDATE' as const;
+export const UPDATE_ERRORS = 'jsonforms/UPDATE_ERRORS' as const;
+export const VALIDATE = 'jsonforms/VALIDATE' as const;
+export const ADD_RENDERER = 'jsonforms/ADD_RENDERER' as const;
+export const REMOVE_RENDERER = 'jsonforms/REMOVE_RENDERER' as const;
+export const ADD_CELL = 'jsonforms/ADD_CELL' as const;
+export const REMOVE_CELL = 'jsonforms/REMOVE_CELL' as const;
+export const SET_CONFIG = 'jsonforms/SET_CONFIG' as const;
+export const ADD_UI_SCHEMA = 'jsonforms/ADD_UI_SCHEMA' as const;
+export const REMOVE_UI_SCHEMA = 'jsonforms/REMOVE_UI_SCHEMA' as const;
+export const SET_SCHEMA = 'jsonforms/SET_SCHEMA' as const;
+export const SET_UISCHEMA = 'jsonforms/SET_UISCHEMA' as const;
+export const SET_VALIDATION_MODE = 'jsonforms/SET_VALIDATION_MODE' as const;
+
+export const SET_LOCALE = 'jsonforms/SET_LOCALE' as const;
+export const SET_TRANSLATOR = 'jsonforms/SET_TRANSLATOR' as const;
+export const UPDATE_I18N = 'jsonforms/UPDATE_I18N' as const;
+
+export const ADD_DEFAULT_DATA = 'jsonforms/ADD_DEFAULT_DATA' as const;
+export const REMOVE_DEFAULT_DATA = 'jsonforms/REMOVE_DEFAULT_DATA' as const;
 
 export type CoreActions =
   | InitAction

packages/core/src/generators/Generate.ts

@@ -28,6 +28,8 @@ import { createControlElement, generateDefaultUISchema } from './uischema';
 import type { ControlElement, JsonSchema, UISchemaElement } from '../';
 
 export const Generate: {
+  // TODO fix @typescript-eslint/ban-types
+  // eslint-disable-next-line @typescript-eslint/ban-types
   jsonSchema(instance: Object, options?: any): JsonSchema;
   uiSchema(
     jsonSchema: JsonSchema,

packages/core/src/generators/schema.ts

@@ -52,6 +52,8 @@ class Gen {
     private findOption: (props: Properties) => (optionName: string) => any
   ) {}
 
+  // TODO fix @typescript-eslint/ban-types
+  // eslint-disable-next-line @typescript-eslint/ban-types
   schemaObject = (data: Object): JsonSchema4 => {
     const props: Properties = this.properties(data);
     const schema: JsonSchema4 = {
@@ -143,6 +145,8 @@ class Gen {
  * @returns {JsonSchema} the generated schema
  */
 export const generateJsonSchema = (
+  // TODO fix @typescript-eslint/ban-types
+  // eslint-disable-next-line @typescript-eslint/ban-types
   instance: Object,
   options: any = {}
 ): JsonSchema4 => {