Handle when equals sign shows up in a parameter (microsoft#265737)

ref microsoft#265733

Author: TylerLeonhardt

src/vs/base/common/oauth.ts

@@ -872,19 +872,27 @@ export function parseWWWAuthenticateHeader(wwwAuthenticateHeaderValue: string):
 					currentChallenge = { scheme: beforeSpace.trim(), params: {} };
 
 					// Parse the parameter part
-					const [key, value] = afterSpace.split('=').map(s => s.trim().replace(/"/g, ''));
-					if (key && value !== undefined) {
-						currentChallenge.params[key] = value;
+					const equalIndex = afterSpace.indexOf('=');
+					if (equalIndex > 0) {
+						const key = afterSpace.substring(0, equalIndex).trim();
+						const value = afterSpace.substring(equalIndex + 1).trim().replace(/^"|"$/g, '');
+						if (key && value !== undefined) {
+							currentChallenge.params[key] = value;
+						}
 					}
 					continue;
 				}
 			}
 
 			// This is a parameter for the current challenge
 			if (currentChallenge) {
-				const [key, value] = token.split('=').map(s => s.trim().replace(/"/g, ''));
-				if (key && value !== undefined) {
-					currentChallenge.params[key] = value;
+				const equalIndex = token.indexOf('=');
+				if (equalIndex > 0) {
+					const key = token.substring(0, equalIndex).trim();
+					const value = token.substring(equalIndex + 1).trim().replace(/^"|"$/g, '');
+					if (key && value !== undefined) {
+						currentChallenge.params[key] = value;
+					}
 				}
 			}
 		}

src/vs/base/test/common/oauth.test.ts

@@ -344,6 +344,15 @@ suite('OAuth', () => {
 			});
 		});
 
+		test('parseWWWAuthenticateHeader should correctly parse parameters with equal signs', () => {
+			const result = parseWWWAuthenticateHeader('Bearer resource_metadata="https://example.com/.well-known/oauth-protected-resource?v=1"');
+			assert.strictEqual(result.length, 1);
+			assert.strictEqual(result[0].scheme, 'Bearer');
+			assert.deepStrictEqual(result[0].params, {
+				resource_metadata: 'https://example.com/.well-known/oauth-protected-resource?v=1'
+			});
+		});
+
 		test('parseWWWAuthenticateHeader should correctly parse multiple', () => {
 			const result = parseWWWAuthenticateHeader('Bearer realm="api", error="invalid_token", error_description="The access token expired", Basic realm="hi"');