Dispose of child InstantiationServices in MonacoEditor (eclipse-theia#15246)

colin-grant-work · web-flow · commit 2a2c0bab5bfc · 2025-03-25T08:02:14.000-06:00
diff --git a/packages/monaco/src/browser/monaco-editor.ts b/packages/monaco/src/browser/monaco-editor.ts
@@ -198,7 +198,9 @@ export class MonacoEditor extends MonacoEditorServices implements TextEditor {
         const instantiator = StandaloneServices.get(IInstantiationService);
         if (override) {
             const overrideServices = new ServiceCollection(...override);
-            return instantiator.createChild(overrideServices);
+            const child = instantiator.createChild(overrideServices);
+            this.toDispose.push(child);
+            return child;
         }
         return instantiator;
     }

Original file line number	Diff line number	Diff line change
`@@ -198,7 +198,9 @@ export class MonacoEditor extends MonacoEditorServices implements TextEditor {`
`198`	`198`	`const instantiator = StandaloneServices.get(IInstantiationService);`
`199`	`199`	`if (override) {`
`200`	`200`	`const overrideServices = new ServiceCollection(...override);`
`201`		`- return instantiator.createChild(overrideServices);`
	`201`	`+ const child = instantiator.createChild(overrideServices);`
	`202`	`+ this.toDispose.push(child);`
	`203`	`+ return child;`
`202`	`204`	`}`
`203`	`205`	`return instantiator;`
`204`	`206`	`}`