Released 1.4.1

Author: ecmel

package.json

@@ -2,7 +2,7 @@
 	"name": "vscode-html-css",
 	"displayName": "HTML CSS Support",
 	"description": "CSS Intellisense for HTML",
-	"version": "1.4.0",
+	"version": "1.4.1",
 	"publisher": "ecmel",
 	"license": "MIT",
 	"homepage": "https://github.com/ecmel/vscode-html-css",

src/completion.ts

@@ -9,7 +9,6 @@ import {
     CompletionItemProvider,
     CompletionList,
     Diagnostic,
-    DiagnosticCollection,
     DiagnosticSeverity,
     Disposable,
     languages,
@@ -28,22 +27,19 @@ export class ClassCompletionItemProvider implements CompletionItemProvider, Disp
     readonly cache = new Map<string, Map<string, CompletionItem>>();
     readonly extends = new Map<string, Set<string>>();
     readonly watchers = new Map<string, Disposable>();
-    readonly collection: DiagnosticCollection;
+    readonly collection = languages.createDiagnosticCollection();
     readonly isRemote = /^https?:\/\//i;
     readonly canComplete = /(id|class|className)\s*=\s*("|')(?:(?!\2).)*$/si;
     readonly findLinkRel = /rel\s*=\s*("|')((?:(?!\1).)+)\1/si;
     readonly findLinkHref = /href\s*=\s*("|')((?:(?!\1).)+)\1/si;
     readonly findExtended = /(?:{{<|{%\s*extends|@extends\s*\()\s*("|')?([./A-Za-z_0-9\\\-]+)\1\s*(?:\)|%}|}})/i;
 
-    constructor(collection: DiagnosticCollection) {
-        this.collection = collection;
-    }
-
     dispose() {
         this.watchers.forEach(v => v.dispose());
         this.cache.clear();
         this.extends.clear();
         this.watchers.clear();
+        this.collection.dispose();
     }
 
     watchFile(uri: Uri, listener: (e: Uri) => any) {

src/extension.ts

@@ -4,8 +4,7 @@ import { ExtensionContext, languages, workspace, commands } from "vscode";
 export function activate(context: ExtensionContext) {
     const config = workspace.getConfiguration("css");
     const enabledLanguages = config.get<string[]>("enabledLanguages", ["html"]);
-    const collection = languages.createDiagnosticCollection();
-    const provider = new ClassCompletionItemProvider(collection);
+    const provider = new ClassCompletionItemProvider();
 
     workspace.textDocuments.forEach(document => {
         if (enabledLanguages.includes(document.languageId)) {
@@ -34,7 +33,6 @@ export function activate(context: ExtensionContext) {
             provider
         ),
 
-        collection,
         provider
     );
 }

src/test/suite/completion.test.ts

@@ -1,24 +1,23 @@
 import * as assert from "assert";
 import { ClassCompletionItemProvider } from "../../completion";
 import { MockCancellationToken, MockCompletionContext, MockDocument } from "./mocks";
-import { CompletionItem, Position, Uri, languages } from "vscode";
+import { CompletionItem, Position, Uri } from "vscode";
 
 suite("ClassCompletionItemProvider Test Suite", () => {
 
-    const collection = languages.createDiagnosticCollection();
     const position = new Position(0, 0);
     const token = new MockCancellationToken(false);
     const context = new MockCompletionContext();
 
     test("RegEx: isRemote", () => {
-        const provider = new ClassCompletionItemProvider(collection);
+        const provider = new ClassCompletionItemProvider();
 
         assert.strictEqual(provider.isRemote.test("http://example.com/example.css"), true);
         assert.strictEqual(provider.isRemote.test("https://example.com/example.css"), true);
     });
 
     test("RegEx: canComplete", () => {
-        const provider = new ClassCompletionItemProvider(collection);
+        const provider = new ClassCompletionItemProvider();
 
         assert.strictEqual(provider.canComplete.test(""), false);
         assert.strictEqual(provider.canComplete.test("class=\""), true);
@@ -53,47 +52,47 @@ suite("ClassCompletionItemProvider Test Suite", () => {
     });
 
     test("RegEx: findLinkRel", () => {
-        const provider = new ClassCompletionItemProvider(collection);
+        const provider = new ClassCompletionItemProvider();
 
         assert.strictEqual(provider.findLinkRel.exec(`
 			<link rel="stylesheet" href="http://example.com/example.css">
 		"`)?.[2], "stylesheet");
     });
 
     test("RegEx: findLinkHref", () => {
-        const provider = new ClassCompletionItemProvider(collection);
+        const provider = new ClassCompletionItemProvider();
 
         assert.strictEqual(provider.findLinkHref.exec(`
 			<link rel="stylesheet" href="http://example.com/example.css">
 		"`)?.[2], "http://example.com/example.css");
     });
 
     test("RegEx: findExtended (Twig)", () => {
-        const provider = new ClassCompletionItemProvider(collection);
+        const provider = new ClassCompletionItemProvider();
 
         assert.strictEqual(provider.findExtended.exec(`
             {% extends "base" %}
         `)?.[2], "base");
     });
 
     test("RegEx: findExtended (Mustache)", () => {
-        const provider = new ClassCompletionItemProvider(collection);
+        const provider = new ClassCompletionItemProvider();
 
         assert.strictEqual(provider.findExtended.exec(`
             {{< base }}
         `)?.[2], "base");
     });
 
     test("RegEx: findExtended (Blade)", () => {
-        const provider = new ClassCompletionItemProvider(collection);
+        const provider = new ClassCompletionItemProvider();
 
         assert.strictEqual(provider.findExtended.exec(`
             @extends('base')
         `)?.[2], "base");
     });
 
     test("Rejects outside class attribute", (done) => {
-        const provider = new ClassCompletionItemProvider(collection);
+        const provider = new ClassCompletionItemProvider();
         const document = new MockDocument("<a class=\"\"></a>");
 
         const result = provider.provideCompletionItems(
@@ -106,7 +105,7 @@ suite("ClassCompletionItemProvider Test Suite", () => {
     });
 
     test("Completes from style tag", async () => {
-        const provider = new ClassCompletionItemProvider(collection);
+        const provider = new ClassCompletionItemProvider();
         const document = new MockDocument("<style>.test{}</style><a class=\"");
 
         const items = await (provider.provideCompletionItems(
@@ -119,7 +118,7 @@ suite("ClassCompletionItemProvider Test Suite", () => {
     });
 
     test("Completes from link tag", async () => {
-        const provider = new ClassCompletionItemProvider(collection);
+        const provider = new ClassCompletionItemProvider();
         const document = new MockDocument(`
 			<link 
 				href="https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css" 
@@ -143,7 +142,7 @@ suite("ClassCompletionItemProvider Test Suite", () => {
                     "https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css"
                 ];
             }
-        }(collection);
+        }();
 
         const document = new MockDocument("<a class=\"");