Grid getter in FunctionSpace

[tom-j-h]

Is your feature request related to a problem? Please describe.

I'm working on something where it would be helpful for a FunctionSpace to be able to return a Grid.

If I understand correctly, all FunctionSpaces (excluding Spectral) should have a Grid underlying them in some way, whether that's directly ((Block)StructuredColumns), via the Mesh (Cell/Edge/NodeColumns), or implicitly via a list of Points (PointCloud).

Describe the solution you'd like

Could we have a getter in FunctionSpace, with implementations in each of the individual types except Spectral? This should be simple for the xColumns FunctionSpaces. PointCloud is trickier - I think we could generate a Grid on the fly using iterate() and return that, or return a Grid that was copied on construction of the PointCloud if it was constructed with one.

Describe alternatives you've considered

At the moment, I think I'd have to dynamic_cast to get the FunctionSpace of particualr type from the base FunctionSpace, then get Grids in the same way as described above.

Additional context

My use case is that we are implementing a simple parallel NetCDF I/O system for FieldSets in JEDI-OOPS. The first step before writing is to redistribute the data (using Redistribution) to a FunctionSpace on the same Grid as the native Fields (hence the need to obtain the grid) but who's Distribution is simply putting ~equal numbers of points onto each PE in order of Atlas's global index. The data is then written to the file in that order so that the files are agnostic to the number of PEs/domain decomposition of the native Fields. For reading the data back in, we do the reverse.

Organisation

Met Office

[tom-j-h]

I've just updated the title and description a bit.

[wdeconinck]

I think this would be a good change and one I had been considering for a while.
The one concern I had, as you pointed out were the FunctionSpaces that have no attached grid.

But also as you pointed out these could be created except for the Spectral.

• PointCloud
• Mesh-based such as NodeColumns, CellColumns. It is not guaranteed that these have an attached grid, if they have just been created by a mesh reader or other means. In that case the same suggested procedure as for PointCloud could be done and a unstructured grid would need to be created.

[tom-j-h]

Thanks for your comment, I wasn't aware that those types may need to construct a Grid too.

@mo-jonasganderton is also interested in adding this functionality and has some ideas on how to improve the PR. We can let you know when it's ready for review.

[tom-j-h]

I've just made some updates to the PR.

[wdeconinck]

Thanks @tom-j-h I merged the PR. I can close the issue now. Your contribution is much appreciated.