Remove using namespace std/boost

Author: marcosbento

libs/attribute/src/ecflow/attribute/DateAttr.cpp

@@ -20,7 +20,6 @@
 #include "ecflow/core/Extract.hpp"
 #include "ecflow/core/Serialization.hpp"
 
-using namespace std;
 using namespace ecf;
 
 //==========================================================================================

libs/attribute/src/ecflow/attribute/DayAttr.cpp

@@ -20,7 +20,6 @@
 #include "ecflow/core/Serialization.hpp"
 #include "ecflow/core/cereal_boost_time.hpp"
 
-using namespace std;
 using namespace ecf;
 
 // #define DEBUG_DAYS 1

libs/attribute/src/ecflow/attribute/GenericAttr.cpp

@@ -16,8 +16,6 @@
 #include "ecflow/core/Str.hpp"
 
 using namespace ecf;
-using namespace boost;
-using namespace std;
 
 const GenericAttr& GenericAttr::EMPTY() {
     static const GenericAttr GENERICATTR = GenericAttr();
@@ -27,14 +25,14 @@ const GenericAttr& GenericAttr::EMPTY() {
 GenericAttr::GenericAttr(const std::string& name, const std::vector<std::string>& values)
     : name_(name),
       values_(values) {
-    string msg;
+    std::string msg;
     if (!Str::valid_name(name, msg)) {
         throw std::runtime_error("GenericAttr::GenericAttr : Invalid generic name : " + msg);
     }
 }
 
 GenericAttr::GenericAttr(const std::string& name) : name_(name) {
-    string msg;
+    std::string msg;
     if (!Str::valid_name(name, msg)) {
         throw std::runtime_error("GenericAttr::GenericAttr : Invalid generic name : " + msg);
     }

libs/attribute/src/ecflow/attribute/LateAttr.cpp

@@ -19,8 +19,6 @@
 #include "ecflow/core/Str.hpp"
 #include "ecflow/core/TimeSeries.hpp"
 
-using namespace std;
-
 namespace ecf {
 
 LateAttr::LateAttr() = default;

libs/attribute/src/ecflow/attribute/NodeAttr.cpp

@@ -18,7 +18,6 @@
 #include "ecflow/core/Serialization.hpp"
 #include "ecflow/core/Str.hpp"
 
-using namespace std;
 using namespace ecf;
 
 const std::string& Event::SET() {
@@ -50,7 +49,7 @@ Event::Event(int number, const std::string& eventName, bool iv, bool check_name)
       v_(iv),
       iv_(iv) {
     if (!eventName.empty() && check_name) {
-        string msg;
+        std::string msg;
         if (!Str::valid_name(eventName, msg)) {
             throw std::runtime_error("Event::Event: Invalid event name : " + msg);
         }
@@ -83,7 +82,7 @@ Event::Event(const std::string& eventName, bool iv) : n_(eventName), v_(iv), iv_
         }
     }
 
-    string msg;
+    std::string msg;
     if (!Str::valid_name(eventName, msg)) {
         throw std::runtime_error("Event::Event: Invalid event name : " + msg);
     }

libs/attribute/src/ecflow/attribute/QueueAttr.cpp

@@ -17,7 +17,6 @@
 #include "ecflow/core/Serialization.hpp"
 #include "ecflow/core/Str.hpp"
 
-using namespace std;
 using namespace ecf;
 
 /////////////////////////////////////////////////////////////////////////////////////////////
@@ -34,7 +33,7 @@ QueueAttr& QueueAttr::EMPTY1() {
 QueueAttr::QueueAttr(const std::string& name, const std::vector<std::string>& theQueue)
     : theQueue_(theQueue),
       name_(name) {
-    string msg;
+    std::string msg;
     if (!Str::valid_name(name, msg)) {
         throw std::runtime_error("QueueAttr::QueueAttr: Invalid queue name : " + msg);
     }
@@ -279,7 +278,7 @@ void QueueAttr::set_state_vec(const std::vector<NState::State>& state_vec) {
 }
 
 void QueueAttr::set_name(const std::string& name) {
-    string msg;
+    std::string msg;
     if (!Str::valid_name(name, msg)) {
         throw std::runtime_error("QueueAttr::set_name: Invalid queue name : " + msg);
     }

libs/attribute/src/ecflow/attribute/RepeatAttr.cpp

@@ -21,7 +21,6 @@
 #include "ecflow/core/Str.hpp"
 #include "ecflow/node/formatter/DefsWriter.hpp"
 
-using namespace std;
 using namespace ecf;
 
 const Repeat& Repeat::EMPTY() {
@@ -350,7 +349,7 @@ std::string RepeatDate::valueAsString() const {
     catch (const ecf::bad_conversion&) {
         LOG_ASSERT(false, "RepeatDate::valueAsString(): could not convert value " << value_ << " to a string");
     }
-    return string();
+    return std::string();
 }
 
 std::string RepeatDate::value_as_string(int index) const {
@@ -360,7 +359,7 @@ std::string RepeatDate::value_as_string(int index) const {
     }
     catch (const ecf::bad_conversion&) {
     }
-    return string();
+    return std::string();
 }
 
 std::string RepeatDate::next_value_as_string() const {
@@ -372,7 +371,7 @@ std::string RepeatDate::next_value_as_string() const {
     }
     catch (const ecf::bad_conversion&) {
     }
-    return string();
+    return std::string();
 }
 
 std::string RepeatDate::prev_value_as_string() const {
@@ -384,7 +383,7 @@ std::string RepeatDate::prev_value_as_string() const {
     }
     catch (const ecf::bad_conversion&) {
     }
-    return string();
+    return std::string();
 }
 
 void RepeatDate::increment() {
@@ -988,7 +987,7 @@ std::string RepeatDateList::valueAsString() const {
 
 std::string RepeatDateList::value_as_string(int index) const {
     if (list_.empty()) {
-        return string("0");
+        return std::string("0");
     }
     if (index >= 0 && index < static_cast<int>(list_.size())) {
         return ecf::convert_to<std::string>(list_[index]);
@@ -1004,7 +1003,7 @@ std::string RepeatDateList::value_as_string(int index) const {
 
 std::string RepeatDateList::next_value_as_string() const {
     if (list_.empty()) {
-        return string("0");
+        return std::string("0");
     }
 
     int index = currentIndex_;
@@ -1014,7 +1013,7 @@ std::string RepeatDateList::next_value_as_string() const {
 
 std::string RepeatDateList::prev_value_as_string() const {
     if (list_.empty()) {
-        return string("0");
+        return std::string("0");
     }
 
     int index = currentIndex_;
@@ -1276,7 +1275,7 @@ std::string RepeatInteger::valueAsString() const {
     catch (const ecf::bad_conversion&) {
         LOG_ASSERT(false, "");
     }
-    return string();
+    return std::string();
 }
 
 std::string RepeatInteger::value_as_string(int index) const {
@@ -1286,7 +1285,7 @@ std::string RepeatInteger::value_as_string(int index) const {
     }
     catch (const ecf::bad_conversion&) {
     }
-    return string();
+    return std::string();
 }
 
 std::string RepeatInteger::next_value_as_string() const {
@@ -1297,7 +1296,7 @@ std::string RepeatInteger::next_value_as_string() const {
     }
     catch (const ecf::bad_conversion&) {
     }
-    return string();
+    return std::string();
 }
 
 std::string RepeatInteger::prev_value_as_string() const {
@@ -1308,7 +1307,7 @@ std::string RepeatInteger::prev_value_as_string() const {
     }
     catch (const ecf::bad_conversion&) {
     }
-    return string();
+    return std::string();
 }
 
 //======================================================================================
@@ -1428,7 +1427,7 @@ std::string RepeatEnumerated::value_as_string(int index) const {
 
 std::string RepeatEnumerated::next_value_as_string() const {
     if (theEnums_.empty()) {
-        return string();
+        return std::string();
     }
 
     int index = currentIndex_;
@@ -1444,7 +1443,7 @@ std::string RepeatEnumerated::next_value_as_string() const {
 
 std::string RepeatEnumerated::prev_value_as_string() const {
     if (theEnums_.empty()) {
-        return string();
+        return std::string();
     }
 
     int index = currentIndex_;
@@ -1597,7 +1596,7 @@ std::string RepeatString::next_value_as_string() const {
         }
         return theStrings_[index];
     }
-    return string();
+    return std::string();
 }
 
 std::string RepeatString::prev_value_as_string() const {
@@ -1612,7 +1611,7 @@ std::string RepeatString::prev_value_as_string() const {
         }
         return theStrings_[index];
     }
-    return string();
+    return std::string();
 }
 
 void RepeatString::increment() {

libs/attribute/src/ecflow/attribute/TodayAttr.cpp

@@ -20,8 +20,6 @@
 #include "ecflow/core/Serialization.hpp"
 #include "ecflow/core/Str.hpp"
 
-using namespace std;
-
 namespace ecf {
 
 TodayAttr::TodayAttr(const std::string& str) {

libs/attribute/src/ecflow/attribute/Variable.cpp

@@ -16,7 +16,6 @@
 #include "ecflow/core/Serialization.hpp"
 #include "ecflow/core/Str.hpp"
 
-using namespace std;
 using namespace ecf;
 
 // init static's

libs/attribute/src/ecflow/attribute/Zombie.cpp

@@ -15,7 +15,6 @@
 #include "ecflow/core/Serialization.hpp"
 
 using namespace ecf;
-using namespace std;
 
 // support return by reference
 const Zombie& Zombie::EMPTY() {
@@ -273,17 +272,17 @@ std::string Zombie::pretty_print(const std::vector<Zombie>& zombies, int indent)
 }
 
 void Zombie::pretty_print(const std::vector<Zombie>& zombies, std::vector<std::string>& list, int indent) {
-    string path("task-path");
-    string type("type");
-    string password("password");
-    string rid("pid");
-    string duration("age(s)");
-    string calls("calls");
-    string try_no("try_no");
-    string user_action("action");
-    string child_type("child");
-    string host("host");
-    string explanation("explanation");
+    std::string path("task-path");
+    std::string type("type");
+    std::string password("password");
+    std::string rid("pid");
+    std::string duration("age(s)");
+    std::string calls("calls");
+    std::string try_no("try_no");
+    std::string user_action("action");
+    std::string child_type("child");
+    std::string host("host");
+    std::string explanation("explanation");
 
     size_t path_width        = path.size();
     size_t type_width        = type.size();
@@ -353,11 +352,12 @@ void Zombie::pretty_print(const std::vector<Zombie>& zombies, std::vector<std::s
                 ss << " ";
             }
         }
-        ss << left << setw(path_width) << path << " " << setw(type_width) << type << " " << setw(duration_width)
-           << duration << " " << setw(password_width) << password << " " << setw(rid_width) << rid << " "
-           << setw(tryno_width) << try_no << " " << setw(user_action_width) << user_action << " "
-           << setw(child_type_width) << child_type << " " << setw(calls_width) << calls << " " << setw(host_width)
-           << host << " " << setw(explanation_width) << explanation;
+        ss << std::left << std::setw(path_width) << path << " " << std::setw(type_width) << type << " "
+           << std::setw(duration_width) << duration << " " << std::setw(password_width) << password << " "
+           << std::setw(rid_width) << rid << " " << std::setw(tryno_width) << try_no << " "
+           << std::setw(user_action_width) << user_action << " " << std::setw(child_type_width) << child_type << " "
+           << std::setw(calls_width) << calls << " " << std::setw(host_width) << host << " "
+           << std::setw(explanation_width) << explanation;
         list.push_back(ss.str());
     }
 
@@ -394,12 +394,12 @@ void Zombie::pretty_print(const std::vector<Zombie>& zombies, std::vector<std::s
                 break;
         }
 
-        ss << left << setw(path_width) << z.path_to_task() << " " << setw(type_width) << z.type_str() << " "
-           << setw(duration_width) << z.duration() << " " << setw(password_width) << z.jobs_password() << " "
-           << setw(rid_width) << z.process_or_remote_id() << " " << setw(tryno_width) << z.try_no() << " "
-           << setw(user_action_width) << z.user_action_str() << " " << setw(child_type_width)
-           << Child::to_string(z.last_child_cmd()) << " " << setw(calls_width) << z.calls() << " " << setw(host_width)
-           << z.host() << " " << setw(explanation_width) << exp;
+        ss << std::left << std::setw(path_width) << z.path_to_task() << " " << std::setw(type_width) << z.type_str()
+           << " " << std::setw(duration_width) << z.duration() << " " << std::setw(password_width) << z.jobs_password()
+           << " " << std::setw(rid_width) << z.process_or_remote_id() << " " << std::setw(tryno_width) << z.try_no()
+           << " " << std::setw(user_action_width) << z.user_action_str() << " " << std::setw(child_type_width)
+           << Child::to_string(z.last_child_cmd()) << " " << std::setw(calls_width) << z.calls() << " "
+           << std::setw(host_width) << z.host() << " " << std::setw(explanation_width) << exp;
         list.push_back(ss.str());
     }
 }