Skip to content

Commit 5501aa4

Browse files
committed
Merge branch 'release/1.32.0'
2 parents 4e1c060 + 8ec88de commit 5501aa4

File tree

5 files changed

+16
-12
lines changed

5 files changed

+16
-12
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,5 @@ doc/latex
1010
.vscode
1111
.idea
1212
build/
13+
tests/geo/eckit_geo_cache
1314
*.ccls-cache

share/eckit/geo/FESOM.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22

3-
url_prefix: &url_prefix https://sites.ecmwf.int/repository/eckit/geo/grid/fesom/
3+
url_prefix: &url_prefix https://get.ecmwf.int/repository/eckit/geo/grid/fesom/
44

55
grid_names:
66
- pi_C: &pi_C

share/eckit/geo/ORCA.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22

3-
url_prefix: &url_prefix https://sites.ecmwf.int/repository/atlas/grids/orca/v0/
3+
url_prefix: &url_prefix https://get.ecmwf.int/repository/atlas/grids/orca/v0/
44

55
grid_names:
66
- ORCA2_F: &ORCA2_F

tests/geo/cache.cc

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,8 +127,9 @@ CASE("download: error handling") {
127127
EXPECT_THROWS_AS(cache::Download::to_path("https://does.not/exist", path), UserError);
128128
EXPECT(!path.exists());
129129

130-
EXPECT_THROWS_AS(cache::Download::to_path("https://sites.ecmwf.int/repository/does/not/exist", path), UserError);
131-
EXPECT(!path.exists());
130+
// This page does not exists but sites.ecmwf.int is answering with an error page, so the test fails
131+
// EXPECT_THROWS_AS(cache::Download::to_path("https://sites.ecmwf.int/repository/does/not/exist", path), UserError);
132+
// EXPECT(!path.exists());
132133
}
133134

134135

tests/geo/integration/CMakeLists.txt

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -176,21 +176,23 @@ foreach(gridspec shape IN ZIP_LISTS TESTS SHAPES)
176176
string(REGEX REPLACE "_$" "" name "${name}")
177177

178178
ecbuild_add_test(
179-
TARGET ${name}_gridspec
180-
COMMAND eckit_grid_spec
181-
ARGS "${gridspec}"
182-
ENVIRONMENT "ECKIT_GEO_CACHE_PATH=${CMAKE_CURRENT_SOURCE_DIR}/../eckit_geo_cache" )
179+
TARGET ${name}_gridspec
180+
COMMAND eckit_grid_spec
181+
ARGS "${gridspec}"
182+
TEST_DEPENDS eckit_test_geo_cache
183+
ENVIRONMENT "ECKIT_GEO_CACHE_PATH=${CMAKE_CURRENT_SOURCE_DIR}/../eckit_geo_cache" )
183184

184185
string(REPLACE "[" [=[\[]=] regex "${gridspec}")
185186
string(REPLACE "]" [=[\]]=] regex "${regex}")
186187

187188
set_tests_properties(${name}_gridspec PROPERTIES PASS_REGULAR_EXPRESSION "${regex}")
188189

189190
ecbuild_add_test(
190-
TARGET ${name}_shape
191-
COMMAND eckit_grid_spec
192-
ARGS "${gridspec}" --shape
193-
ENVIRONMENT "ECKIT_GEO_CACHE_PATH=${CMAKE_CURRENT_SOURCE_DIR}/../eckit_geo_cache" )
191+
TARGET ${name}_shape
192+
COMMAND eckit_grid_spec
193+
ARGS "${gridspec}" --shape
194+
TEST_DEPENDS eckit_test_geo_cache
195+
ENVIRONMENT "ECKIT_GEO_CACHE_PATH=${CMAKE_CURRENT_SOURCE_DIR}/../eckit_geo_cache" )
194196

195197
string(REPLACE "[" [=[\[]=] regex "${shape}")
196198
string(REPLACE "]" [=[\]]=] regex "${regex}")

0 commit comments

Comments
 (0)