Python 3.7 compatibility broken

[Rulrn]

What happened?

The recently added readers module has incompatible code for python3.7 in it's init.py (maybe in others module too, did not checked)

What are the steps to reproduce the bug?

$ python -c "import pdbufr.readers"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/user/pyve/venv/lib/python3.7/site-packages/pdbufr/__init__.py", line 20, in <module>
    from .readers.generic import stream_bufr
  File "/home/user/pyve/venv/lib/python3.7/site-packages/pdbufr/readers/__init__.py", line 79, in <module>
    class ReaderMaker:
  File "/home/user/pyve/venv/lib/python3.7/site-packages/pdbufr/readers/__init__.py", line 114, in ReaderMaker
    def get(self, name: str) -> type[Reader]:
TypeError: 'type' object is not subscriptable

This can be fixed by importing from typing import Type and replacing the signature. Or by importing from __future__ import annotations as it make new typing signatures python3.7 compatible.

Version

0.14.0

Platform (OS and architecture)

Linux - debian 10.11

Relevant log output

Accompanying data

No response

Organisation

No response

[iainrussell]

Hi @Rulrn, many thanks for your input. In fact, we intend to bump up the minimum required version of Python for pdbufr to 3.9 to match that used by ecCodes (on which pdbufr relies). Python 3.9 is also the lowest officially supported version by the Python maintainers. I would suggest that you update your environment to a newer version of Python.

One intermediate solution could be if you were able to provide a Pull Request in the next few weeks with the changes necessary to support 3.7 (we do not have Python 3.7 installed and cannot devote time to testing on it). If those changes are compatible with newer versions of Python, we could merge it in for one last release before increasing the minimum supported Python version.

[Rulrn]

Hi,
I managed to make my projects work using a version prior to 0.13.0. Unfortunately, I will not find the time to make pdbufr python 3.7 compatible in the following weeks, and as you pointed out, I should update my environment instead.

Thank you for your response, I think you can close this issue.