Ignore ranges in package versions

Author: SteveDesmond-ca

src/LibYear.Core/FileTypes/XmlProjectFile.cs

@@ -44,7 +44,7 @@ public string Update(IReadOnlyCollection<Result> results)
 		var version = element.Attribute(versionAttributeName)?.Value ?? element.Element(versionAttributeName)?.Value ?? string.Empty;
 		try
 		{
-			return !string.IsNullOrEmpty(version)
+			return !string.IsNullOrEmpty(version) && !version.Any(v => PackageVersion.RangeChars.Contains(v))
 				? new PackageVersion(version)
 				: null;
 		}

src/LibYear.Core/PackageVersion.cs

@@ -4,6 +4,8 @@ namespace LibYear.Core;
 
 public sealed class PackageVersion : NuGetVersion
 {
+	public const string RangeChars = "[],()";
+
 	public WildcardType WildcardType { get; }
 
 	public PackageVersion(string version)
@@ -46,7 +48,8 @@ private static PackageVersion ParseVersionString(string versionString)
 
 		if (wildcard == WildcardType.None)
 		{
-			return new PackageVersion(new NuGetVersion(versionString), wildcard);
+			var nuGetVersion = new NuGetVersion(versionString);
+			return new PackageVersion(nuGetVersion, wildcard);
 		}
 
 		var lastPeriod = versionString.LastIndexOf('.');

test/LibYear.Core.Tests/FileTypes/CsProjFileTests.cs

@@ -15,13 +15,15 @@ public async Task CanLoadCsProjFile()
 		var file = new CsProjFile(filename, await File.ReadAllTextAsync(filename));
 
 		//assert
-		Assert.Equal("test1", file.Packages.First().Key);
-		Assert.Equal("test2", file.Packages.Skip(1).First().Key);
-		Assert.Equal("test3", file.Packages.Skip(2).First().Key);
-		Assert.Equal("test4", file.Packages.Skip(3).First().Key);
-		Assert.Equal("test5", file.Packages.Skip(4).First().Key);
-		Assert.Equal("test6", file.Packages.Skip(5).First().Key);
-		Assert.Equal("test7", file.Packages.Skip(6).First().Key);
+		var packages = file.Packages.Keys.ToArray();
+		Assert.Equal("test1", packages[0]);
+		Assert.Equal("test2", packages[1]);
+		Assert.Equal("test3", packages[2]);
+		Assert.Equal("test4", packages[3]);
+		Assert.Equal("test5", packages[4]);
+		Assert.Equal("test6", packages[5]);
+		Assert.Equal("test7", packages[6]);
+		Assert.Equal("test8", packages[7]);
 	}
 
 	[Fact]
@@ -55,7 +57,7 @@ public async Task CanUpdateCsProjFile()
 	}
 
 	[Fact]
-	public async Task InvalidVersionShowsInfo()
+	public async Task InvalidVersionShowsExceptionDetails()
 	{
 		//arrange
 		var filename = Path.Combine("FileTypes", "project.csproj");
@@ -76,4 +78,18 @@ public async Task InvalidVersionShowsInfo()
 			Assert.Contains("project.csproj", e.Message);
 		}
 	}
+
+	[Fact]
+	public async Task VersionRangeGetsSkipped()
+	{
+		//arrange
+		var filename = Path.Combine("FileTypes", "project.csproj");
+		var contents = await File.ReadAllTextAsync(filename);
+
+		//act
+		var file = new CsProjFile(filename, contents);
+
+		//assert
+		Assert.Null(file.Packages["test8"]);
+	}
 }

test/LibYear.Core.Tests/FileTypes/project.csproj

@@ -19,5 +19,6 @@
     </PackageReference>
     <PackageReference Include="test6" />
     <PackageReference Include="test7" Version="*" />
+    <PackageReference Include="test8" Version="[1.2,2.3]" />
   </ItemGroup>
 </Project>