Skip to content

Commit fc527dc

Browse files
committed
fix(webhook): return api error when shipping line update fails
1 parent 738d3ec commit fc527dc

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

functions/routes/datafrete/webhook.js

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,17 +58,18 @@ exports.post = async ({ appSdk }, req, res) => {
5858
console.log('> Nothing to change on shipping line:', shippingLineId, order._id)
5959
return res.sendStatus(304)
6060
}
61-
res.sendStatus(200)
6261
} else {
6362
try {
64-
const { response: { status } } = await appSdk.apiRequest(
63+
await appSdk.apiRequest(
6564
storeId,
6665
`orders/${order._id}/fulfillments.json`,
6766
'POST',
6867
fulfillment,
6968
auth
7069
)
71-
res.sendStatus(status)
70+
if (!isShippingLineUpdate) {
71+
return res.sendStatus(200)
72+
}
7273
} catch (error) {
7374
console.error(error)
7475
if (error.response && error.response.status) {
@@ -91,6 +92,7 @@ exports.post = async ({ appSdk }, req, res) => {
9192
auth
9293
)
9394
console.log('Shipping line invoices/tracking updated')
95+
res.sendStatus(200)
9496
} catch (error) {
9597
if (error.response) {
9698
let { message } = error
@@ -105,8 +107,11 @@ exports.post = async ({ appSdk }, req, res) => {
105107
message += '\n' + error.config.url
106108
}
107109
console.error(new Error(message))
110+
res.status(error.response.status || 500)
111+
res.send(error.response.data)
108112
} else {
109113
console.error(error)
114+
res.sendStatus(500)
110115
}
111116
}
112117
}

0 commit comments

Comments
 (0)