fix(env): get env vars inside function scope (runtime)

Author: leomp12

lib/services/update-tokens.js

@@ -1,13 +1,6 @@
 'use strict'
 
 const updateTokens = client => {
-  const {
-    ECOM_AUTH_UPDATE_INTERVAL,
-    GCP_PROJECT,
-    GCLOUD_PROJECT,
-    FIREBASE_CONFIG
-  } = process.env
-
   const { collRef, db, table, debug } = client
   // handle access token refresh
   const refreshToken = require('./../methods/refresh-token')(client)
@@ -118,6 +111,13 @@ const updateTokens = client => {
     }
   }
 
+  const {
+    ECOM_AUTH_UPDATE_INTERVAL,
+    GCP_PROJECT,
+    GCLOUD_PROJECT,
+    FIREBASE_CONFIG
+  } = process.env
+
   if (
     ECOM_AUTH_UPDATE_INTERVAL !== 'disabled' &&
     // ignore interval task for Google Cloud Functions by default

main.js

@@ -37,23 +37,14 @@ const envDbFilename = process.env.ECOM_AUTH_DB
 
 // handle new promise
 const promise = new Promise((resolve, reject) => {
-  const {
-    ECOM_AUTH_DEBUG,
-    ECOM_AUTH_UPDATE,
-    ECOM_AUTH_SETUP_TIMEOUT,
-    GCP_PROJECT,
-    GCLOUD_PROJECT,
-    FIREBASE_CONFIG
-  } = process.env
-
   // setup database and table
   setup = (dbFilename, disableUpdates, firestoreDb) => {
     dbFilename = firestoreDb ? null : dbFilename || envDbFilename || process.cwd() + '/db.sqlite3'
     if (!client || client.dbFilename !== dbFilename) {
       const table = 'ecomplus_app_auth'
 
       // setup instance client object
-      const debug = !ECOM_AUTH_DEBUG
+      const debug = !process.env.ECOM_AUTH_DEBUG
         ? null
         : msg => {
           console.log(`[ECOM_AUTH] ${msg}`)
@@ -74,7 +65,7 @@ const promise = new Promise((resolve, reject) => {
           const updateTokens = () => {
             require('./lib/services/update-tokens')(client)
           }
-          if (disableUpdates !== true && ECOM_AUTH_UPDATE !== 'disabled') {
+          if (disableUpdates !== true && process.env.ECOM_AUTH_UPDATE !== 'disabled') {
             // update access tokens periodically
             updateTokens()
           } else if (debug) {
@@ -138,6 +129,13 @@ const promise = new Promise((resolve, reject) => {
     return promise
   }
 
+  const {
+    ECOM_AUTH_SETUP_TIMEOUT,
+    GCP_PROJECT,
+    GCLOUD_PROJECT,
+    FIREBASE_CONFIG
+  } = process.env
+
   if (
     ECOM_AUTH_SETUP_TIMEOUT !== 'disabled' &&
     // ignore setup timeout for Google (Firebase) Cloud Functions by default