fix(modules): Fix handling modules endpoints with URL params (?app_id)

leomp12 · leomp12 · commit f722c5a724be · 2025-07-18T10:55:13.000-03:00
diff --git a/packages/modules/src/firebase/serve-modules-api.ts b/packages/modules/src/firebase/serve-modules-api.ts
@@ -16,10 +16,10 @@ export default (req: Request, res: Response) => {
   }
 
   let { url } = req;
+  [url] = url.split('?');
   if (url.endsWith('.json')) {
     url = url.slice(0, -5);
   }
-  [url] = url.split('?');
   url = url.replace('/_api/modules', ''); // due to hosting rewrite
   const modName = url.split('/')[1];
 

Original file line number	Diff line number	Diff line change
`@@ -16,10 +16,10 @@ export default (req: Request, res: Response) => {`
`16`	`16`	`}`
`17`	`17`
`18`	`18`	`let { url } = req;`
	`19`	`+ [url] = url.split('?');`
`19`	`20`	`if (url.endsWith('.json')) {`
`20`	`21`	`url = url.slice(0, -5);`
`21`	`22`	`}`
`22`		`- [url] = url.split('?');`
`23`	`23`	`url = url.replace('/_api/modules', ''); // due to hosting rewrite`
`24`	`24`	`const modName = url.split('/')[1];`
`25`	`25`