Skip to content

Commit e8f8e00

Browse files
committed
Fix pre-commit CI failures
- Remove trailing whitespace in reproduce/docker/setup.sh - Fix shellcheck SC2269: remove self-assignment in arch case - Add shellcheck disable SC2016 for intentional single quotes in binder/postBuild - Add ruff per-file-ignores for notebooks (E402, F404) - Remove pip-compile hook (project uses uv.lock not requirements.txt)
1 parent 8b13d10 commit e8f8e00

File tree

4 files changed

+9
-11
lines changed

4 files changed

+9
-11
lines changed

.pre-commit-config.yaml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,6 @@ ci:
33
autofix_commit_msg: "style: pre-commit fixes"
44

55
repos:
6-
- repo: https://github.com/astral-sh/uv-pre-commit
7-
rev: 0.8.14
8-
hooks:
9-
- id: pip-compile
10-
args: [pyproject.toml, --output-file, requirements.txt]
11-
files: ^(pyproject\.toml|requirements\.txt)$
12-
136
- repo: https://github.com/pre-commit/pre-commit-hooks
147
rev: "v6.0.0"
158
hooks:

binder/postBuild

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ if os.path.isdir(code_dir) and code_dir not in sys.path:
5959
PYEOF
6060

6161
# Also set for shell sessions
62+
# shellcheck disable=SC2016 # Single quotes are intentional - variables expand at runtime
6263
echo 'export PYTHONPATH="$HOME/code:$PYTHONPATH"' >> ~/.bashrc
6364

6465
# ============================================================================

pyproject.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,10 @@ extend-select = [
4646
"UP", # pyupgrade
4747
]
4848

49+
[tool.ruff.lint.per-file-ignores]
50+
# Notebooks have different import conventions
51+
"*.ipynb" = ["E402", "F404"]
52+
4953

5054

5155
[tool.uv.sources]

reproduce/docker/setup.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ get_platform_venv_path() {
2525
local workspace_dir="$1"
2626
local platform=""
2727
local arch=""
28-
28+
2929
# Detect platform
3030
case "$(uname -s)" in
3131
Darwin)
@@ -47,15 +47,15 @@ get_platform_venv_path() {
4747
return
4848
;;
4949
esac
50-
50+
5151
# Normalize architecture names
5252
case "$arch" in
5353
arm64) arch="arm64" ;; # macOS ARM
5454
aarch64) arch="aarch64" ;; # Linux ARM
5555
x86_64) arch="x86_64" ;; # Both platforms
56-
*) arch="$arch" ;; # Other
56+
*) ;; # Keep original value
5757
esac
58-
58+
5959
echo "$workspace_dir/.venv-$platform-$arch"
6060
}
6161

0 commit comments

Comments
 (0)