Remove fragment caching from advisories index and increase HTTP cache TTL

Drop cached: true from index jbuilder to avoid writing oversized objects
to memcached. Increase expires_in from 5 minutes to 1 hour on index,
packages, and lookup endpoints.

Author: andrew

app/controllers/api/v1/advisories_controller.rb

@@ -1,6 +1,6 @@
 class Api::V1::AdvisoriesController < Api::V1::ApplicationController
   def index
-    expires_in 5.minutes, public: true, stale_while_revalidate: 1.hour
+    expires_in 1.hour, public: true, stale_while_revalidate: 1.hour
 
     scope = Advisory.all
 
@@ -32,7 +32,7 @@ def show
   end
 
   def packages
-    expires_in 5.minutes, public: true, stale_while_revalidate: 1.hour
+    expires_in 1.hour, public: true, stale_while_revalidate: 1.hour
 
     render json: Advisory.packages
   end
@@ -58,7 +58,7 @@ def lookup
       return
     end
 
-    expires_in 5.minutes, public: true, stale_while_revalidate: 1.hour
+    expires_in 1.hour, public: true, stale_while_revalidate: 1.hour
 
     advisories = Advisory.ecosystem(parsed_purl[:ecosystem])
                         .package_name(parsed_purl[:package_name])

app/views/api/v1/advisories/index.json.jbuilder

@@ -1 +1 @@
-json.partial! 'api/v1/advisories/advisory', collection: @advisories, as: :advisory, cached: true
+json.partial! 'api/v1/advisories/advisory', collection: @advisories, as: :advisory

test/controllers/api/v1/advisories_controller_test.rb

@@ -20,7 +20,7 @@ class Api::V1::AdvisoriesControllerTest < ActionDispatch::IntegrationTest
   test "should get index" do
     get api_v1_advisories_url, as: :json
     assert_response :success
-    assert_match /max-age=300/, response.headers["Cache-Control"]
+    assert_match /max-age=3600/, response.headers["Cache-Control"]
     assert_match /public/, response.headers["Cache-Control"]
     assert_match /stale-while-revalidate=3600/, response.headers["Cache-Control"]
   end
@@ -143,7 +143,7 @@ class Api::V1::AdvisoriesControllerTest < ActionDispatch::IntegrationTest
   test "should get packages" do
     get packages_api_v1_advisories_url, as: :json
     assert_response :success
-    assert_match /max-age=300/, response.headers["Cache-Control"]
+    assert_match /max-age=3600/, response.headers["Cache-Control"]
     assert_match /public/, response.headers["Cache-Control"]
   end