bad logic when dealing with null values

Author: ryan-dyer-sp

fluent-plugin-elasticsearch-timestamp-check.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "fluent-plugin-elasticsearch-timestamp-check"
-  spec.version       = "0.2.0"
+  spec.version       = "0.2.1"
   spec.authors       = ["Richard Li"]
   spec.email         = ["[email protected]"]
   spec.description   = %q{fluent filter plugin to ensure @timestamp is in proper format}

lib/fluent/plugin/filter_elasticsearch_timestamp_check.rb

@@ -19,15 +19,16 @@ def shutdown
 
     def filter(tag, time, record)
       timestamps = [ record['@timestamp'], record['timestamp'], record['time'] ]
+      valid = false
       timestamps.each do |timestamp|
         begin
-          DateTime.parse(timestamp)
-          valid = timestamp
-          break
+          if timestamp then
+            DateTime.parse(timestamp)
+            valid = timestamp
+            break
+          end
         rescue ArgumentError
           next
-        else
-          valid = false
         end
       end