Merge pull request #184 from razvanphp/master

Add support for DER and P12 certificates

Author: edamov

README.md

@@ -110,7 +110,7 @@ foreach ($responses as $response) {
 }
 ```
 
-Using Certificate (.pem). Only the initilization differs from JWT code (above). Remember to include the rest of the code by yourself.
+Using Certificate (.pem or .p12). Only the initilization differs from JWT code (above). Remember to include the rest of the code by yourself.
 
 ``` php
 <?php

src/AuthProvider/Certificate.php

@@ -76,6 +76,16 @@ public static function create(array $options): Certificate
      */
     public function authenticateClient(Request $request)
     {
+        # OpenSSL (versions 0.9.3 and later) also support "P12" for PKCS#12-encoded files.
+        # see https://curl.se/libcurl/c/CURLOPT_SSLCERTTYPE.html
+        $ext = pathinfo($this->certificatePath, \PATHINFO_EXTENSION);
+        if (preg_match('#^(der|p12)$#i', $ext)) {
+            $request->addOptions(
+                [
+                    CURLOPT_SSLCERTTYPE => strtoupper($ext)
+                ]
+            );
+        }
         $request->addOptions(
             [
                 CURLOPT_SSLCERT        => $this->certificatePath,

tests/AuthProvider/CertificateTest.php

@@ -39,6 +39,27 @@ public function testAuthenticatingClient()
         $this->assertSame($request->getOptions()[CURLOPT_SSLCERTPASSWD], $options['certificate_secret']);
     }
 
+    public function testAuthenticatingClientP12()
+    {
+        $certFile = tempnam(sys_get_temp_dir(), "mock_test_cert");
+        rename($certFile, $certFile .= '.p12');
+        try {
+            $options = [
+                'certificate_path' => $certFile,
+                'certificate_secret' => 'secret',
+                'app_bundle_id' => 'com.apple.test',
+            ];
+            $authProvider = Certificate::create($options);
+
+            $request = $this->createRequest();
+            $authProvider->authenticateClient($request);
+
+            $this->assertSame($request->getOptions()[CURLOPT_SSLCERTTYPE], 'P12');
+        } finally {
+            @\unlink($certFile);
+        }
+    }
+
     public function testVoipApnsTopic()
     {
         $options = $this->getOptions();