Skip to content

Commit a5105fa

Browse files
committed
Fixed demo aot build
1 parent 89acc01 commit a5105fa

File tree

4 files changed

+17
-50
lines changed

4 files changed

+17
-50
lines changed

components/modal/modal.ts

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@ import {ModalConfig, ModalSize} from './modal-config';
99
selector: 'sui-modal',
1010
template: `
1111
<!-- Page dimmer for modal background. -->
12-
<sui-dimmer class="page" [(isDimmed)]="_dimBackground" [isClickable]="false" [transitionDuration]="transitionDuration" (click)="close()"></sui-dimmer>
12+
<sui-dimmer class="page" [(isDimmed)]="dimBackground" [isClickable]="false" [transitionDuration]="transitionDuration" (click)="close()"></sui-dimmer>
1313
<!-- Modal component, with transition component attached -->
1414
<div class="ui modal {{ size }}"
15-
[suiTransition]="_transitionController"
16-
[class.active]="_transitionController?.isVisible"
15+
[suiTransition]="transitionController"
16+
[class.active]="transitionController?.isVisible"
1717
[class.fullscreen]="isFullScreen"
1818
[class.basic]="isBasic"
1919
#modal>
@@ -83,7 +83,7 @@ export class SuiModal<T, U> implements OnInit, AfterViewInit {
8383
@Input()
8484
public isBasic:boolean;
8585

86-
private _transitionController:TransitionController;
86+
public transitionController:TransitionController;
8787

8888
// Transition to display modal with.
8989
@Input()
@@ -94,7 +94,7 @@ export class SuiModal<T, U> implements OnInit, AfterViewInit {
9494
public transitionDuration:number;
9595

9696
// Whether or not the backround dimmer is active.
97-
private _dimBackground:boolean;
97+
public dimBackground:boolean;
9898
// True after `approve` or `deny` has been called.
9999
private _isClosing:boolean;
100100

@@ -118,16 +118,16 @@ export class SuiModal<T, U> implements OnInit, AfterViewInit {
118118
res => this.dismiss(() => this.onDeny.emit(res)));
119119

120120
// Internal variable initialisation.
121-
this._dimBackground = false;
121+
this.dimBackground = false;
122122
this._isClosing = false;
123-
this._transitionController = new TransitionController(false);
123+
this.transitionController = new TransitionController(false);
124124
}
125125

126126
public ngOnInit() {
127127
// Transition the modal to be visible.
128-
this._transitionController.animate(new Transition(this.transition, this.transitionDuration, TransitionDirection.In));
128+
this.transitionController.animate(new Transition(this.transition, this.transitionDuration, TransitionDirection.In));
129129
// Use a slight delay as the `<sui-dimmer>` cancels the initial transition.
130-
setTimeout(() => this._dimBackground = true);
130+
setTimeout(() => this.dimBackground = true);
131131
}
132132

133133
public ngAfterViewInit() {
@@ -156,9 +156,9 @@ export class SuiModal<T, U> implements OnInit, AfterViewInit {
156156
this._isClosing = true;
157157

158158
// Transition the modal to be invisible.
159-
this._dimBackground = false;
160-
this._transitionController.stopAll();
161-
this._transitionController.animate(
159+
this.dimBackground = false;
160+
this.transitionController.stopAll();
161+
this.transitionController.animate(
162162
new Transition(this.transition, this.transitionDuration, TransitionDirection.Out, () => {
163163
// When done, emit a dismiss event, and fire the callback.
164164
this.onDismiss.emit();

demo/src/app/pages/demo-pages.module.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {SuiModule} from '../../../../components';
55
import {DemoComponentsModule} from '../components/demo-components.module';
66

77
import {GettingStartedPage} from './getting-started/getting-started.page';
8-
import {TestPage, AcceptRejectModalComponent} from './test/test.page';
8+
import {TestPage} from './test/test.page';
99

1010
import {AccordionPageComponents} from './accordion/accordion.page';
1111
import {CheckboxPageComponents} from './checkbox/checkbox.page';

demo/src/app/pages/modal/modal.page.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,7 @@ const exampleTemplateModalTemplate = `
1818
</ng-template>
1919
`;
2020

21-
const exampleTemplateTemplate = `
22-
${exampleTemplateModalTemplate}
23-
21+
export const exampleTemplateTemplate = exampleTemplateModalTemplate + `
2422
<div class="ui fluid action input">
2523
<input type="text" placeholder="Modal content..." [(ngModel)]="dynamicContent">
2624
<button class="ui primary button" (click)="open(dynamicContent)">Open</button>
@@ -33,8 +31,8 @@ const exampleComponentModalTemplate = `
3331
<p>{{ modal.context.question }}</p>
3432
</div>
3533
<div class="actions">
36-
<button class="ui red button" (click)="modal.deny()">Cancel</button>
37-
<button class="ui green button" (click)="modal.approve()">OK</button>
34+
<button class="ui red button" (click)="modal.deny(null)">Cancel</button>
35+
<button class="ui green button" (click)="modal.approve(null)">OK</button>
3836
</div>
3937
`;
4038

demo/src/app/pages/test/test.page.ts

Lines changed: 1 addition & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -4,37 +4,6 @@ import {ModalConfig, ComponentModalConfig, TemplateModalConfig, ModalSize} from
44
import {Modal} from '../../../../../components/modal/modal-controls';
55
import {ModalTemplate} from '../../../../../components/modal/modal-template';
66

7-
interface IAcceptRejectModalContext {
8-
title:string;
9-
question:string;
10-
}
11-
12-
@Component({
13-
selector: 'modal-accept-reject',
14-
template: `
15-
<div class="header">{{ modal.context.title }}</div>
16-
<div class="content">
17-
<p>{{ modal.context.question }}</p>
18-
</div>
19-
<div class="actions">
20-
<button class="ui red button" (click)="modal.deny('deny')">Cancel</button>
21-
<button class="ui green button" (click)="modal.approve('approve')">OK</button>
22-
</div>
23-
`
24-
})
25-
export class AcceptRejectModalComponent {
26-
constructor(public modal:Modal<IAcceptRejectModalContext, null>) {}
27-
}
28-
29-
export class AcceptRejectModal extends ComponentModalConfig<IAcceptRejectModalContext> {
30-
constructor(title:string, question:string) {
31-
super(AcceptRejectModalComponent, { title, question }, false);
32-
33-
this.size = ModalSize.Small;
34-
this.isBasic = true;
35-
}
36-
}
37-
387
@Component({
398
selector: 'demo-page-test',
409
templateUrl: './test.page.html'
@@ -48,7 +17,7 @@ export class TestPage implements AfterViewInit {
4817

4918
public ngAfterViewInit() {
5019
// const modal = new TemplateModalInstance<null, string, string>(this.modalTemplate, null, true);
51-
const modal = new AcceptRejectModal("Are you sure?", "Are you sure you want to do this?");
20+
// const modal = new AcceptRejectModal("Are you sure?", "Are you sure you want to do this?");
5221

5322
// modal.closeResult = "default!";
5423

0 commit comments

Comments
 (0)