Skip to content

Commit dbe85c1

Browse files
committed
merge: 'master' into feat(message)/notification-functionality
Conflicts: components/modal/modal.module.ts components/modal/modal.service.ts components/popup/popup.directive.ts components/popup/popup.module.ts components/sui.module.ts components/util/util.ts demo/src/app/pages/development/test/test.page.html demo/src/app/pages/development/test/test.page.ts demo/src/app/pages/modules/accordion/accordion.page.html demo/src/app/pages/modules/popup/popup.page.ts package.json src/collections/message/components/message.ts src/collections/message/message.module.ts src/modules/modal/classes/modal-config.ts src/modules/modal/components/modal.ts tslint.json
1 parent 4491f15 commit dbe85c1

File tree

242 files changed

+19206
-2353
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

242 files changed

+19206
-2353
lines changed

.gitignore

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,19 +28,20 @@
2828
npm-debug.log
2929
testem.log
3030

31-
# System Files
31+
# system files
3232
.DS_Store
3333
Thumbs.db
3434

35-
# Non TS files
35+
# non TS files
3636
*.d.ts
3737
*.metadata.json
3838
*.js
3939
*.js.map
4040

41-
# Config Files
42-
!*.config.js
41+
# build scripts
42+
!scripts/**/*
43+
!package.js
4344

44-
# Output Files
45+
# output files
4546
demo/dist
4647
bundles

.npmignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ npm-debug.log
88
# *.map
99
# *.d.ts
1010
demo
11+
src
1112

1213
# JetBrains
1314
.idea
@@ -24,4 +25,4 @@ Desktop.ini
2425

2526
# TS Files
2627
*.ts
27-
!*.d.ts
28+
!*.d.ts

.travis.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,5 @@ before_install:
77

88
script:
99
- npm run lint
10-
- npm run compile
10+
- npm run compile:lib
11+
- npm run test

CONTRIBUTING.md

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Please read and follow the [Code of Conduct](https://github.com/edcarroll/ng2-se
1515

1616
## Bug, Question or Problem?
1717

18-
For any usage questions you have, you can join [Gitter](https://gitter.im/ng2-semantic-ui/usage-queries) to ask for help.
18+
For any usage questions you have, you can join [Gitter](https://gitter.im/ng2-semantic-ui/Lobby) to ask for help.
1919

2020
If you've found a bug, please submit an issue. Even better would be submitting a Pull Request with a fix.
2121

@@ -37,7 +37,7 @@ and help you to craft the change so that it is successfully accepted into the pr
3737

3838
Before you submit an issue, please search the issue tracker, as an issue for your problem may already exist and the discussion might inform you of readily available workarounds.
3939

40-
Ideally all issues are fixed as soon as possible, but before that can be done the bug must be confirmed. This is done by providing a minimal reproduction scenario using [http://plunkr.co](http://plunkr.co). Having a live, reproducible scenario provides a wealth of important information without needing to go back & forth to you with additional queries such as:
40+
Ideally all issues are fixed as soon as possible, but before that can be done the bug must be confirmed. This is done by providing a minimal reproduction scenario using [http://plunkr.co](http://plunkr.co). You can fork the [ng2-semantic-ui plunkr starter](http://plnkr.co/edit/SJMMMS8wQkwdX1HeMqiH?p=preview) and use it as a starting point. Having a live, reproducible scenario provides a wealth of important information without needing to go back & forth to you with additional queries such as:
4141

4242
* Angular version used
4343
* ng2-semantic-ui version used
@@ -54,6 +54,8 @@ Before submitting a Pull Request (PR) consider the following guidelines:
5454

5555
* Search the Github [pull requests](https://github.com/edcarroll/ng2-semantic-ui/pulls) for an open or closed PR relating to your submission (to avoid duplicating effort).
5656

57+
* Fork a copy of the repository to your own Github account - [see Github guide](https://help.github.com/articles/working-with-forks/)
58+
5759
* Make your changes in a new git branch:
5860

5961
```shell
@@ -72,7 +74,10 @@ Before submitting a Pull Request (PR) consider the following guidelines:
7274
$ git push origin my-fix-branch
7375
```
7476

75-
* In GitHub, send a pull request to `ng2-semantic-ui:master`.
77+
* In GitHub, send a pull request to `ng2-semantic-ui:master`
78+
- Create a new pull request
79+
- Select **compare across forks**
80+
- Set your repo and fix branch as the head fork to compare.
7681

7782
* If changes are suggested:
7883
- Make the required updates

README.md

Lines changed: 56 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<!-- Logo -->
22
<p align="center">
3-
<a href="https://react.semantic-ui.com">
3+
<a href="https://edcarroll.github.io/ng2-semantic-ui/">
44
<img height="128" width="238" src="https://raw.githubusercontent.com/edcarroll/ng2-semantic-ui/master/demo/src/assets/logo.png">
55
</a>
66
</p>
@@ -15,9 +15,15 @@
1515
<a href="https://gitter.im/ng2-semantic-ui/Lobby">
1616
<img alt="Gitter" src="https://img.shields.io/gitter/room/ng2-semantic-ui/Lobby.js.svg?style=flat-square" />
1717
</a>
18+
<a href="https://travis-ci.org/edcarroll/ng2-semantic-ui">
19+
<img alt="Travis CI" src="https://img.shields.io/travis/edcarroll/ng2-semantic-ui.svg?style=flat-square" />
20+
</a>
1821
<a href="https://www.npmjs.com/package/ng2-semantic-ui">
1922
<img alt="npm" src="https://img.shields.io/npm/v/ng2-semantic-ui.svg?style=flat-square" />
2023
</a>
24+
<a href="https://www.npmjs.com/package/ng2-semantic-ui">
25+
<img alt="monthly downloads" src="https://img.shields.io/npm/dm/ng2-semantic-ui.svg?style=flat-square" />
26+
</a>
2127
</p>
2228

2329
Semantic UI Angular Integrations, written in pure Angular - **no JQuery required**.
@@ -34,28 +40,38 @@ See the [Documentation](https://edcarroll.github.io/ng2-semantic-ui) for install
3440

3541
## Dependencies
3642

37-
* [Angular](https://angular.io) (^4.1.0)
43+
* [Angular](https://angular.io) (^4.3.1)
3844
* [Semantic UI CSS](http://semantic-ui.com/) (jQuery is **not** required)
3945

40-
## Components
41-
42-
The current list of available components with links to their docs is below:
43-
44-
* [Accordion](https://edcarroll.github.io/ng2-semantic-ui/#/components/accordion)
45-
* [Checkbox](https://edcarroll.github.io/ng2-semantic-ui/#/components/checkbox)
46-
* [Collapse](https://edcarroll.github.io/ng2-semantic-ui/#/components/collapse)
47-
* [Dimmer](https://edcarroll.github.io/ng2-semantic-ui/#/components/dimmer)
48-
* [Dropdown](https://edcarroll.github.io/ng2-semantic-ui/#/components/dropdown)
49-
* [Message](https://edcarroll.github.io/ng2-semantic-ui/#/components/message)
50-
* [Modal](https://edcarroll.github.io/ng2-semantic-ui/#/components/modal)
51-
* [Popup](https://edcarroll.github.io/ng2-semantic-ui/#/components/popup)
52-
* [Progress](https://edcarroll.github.io/ng2-semantic-ui/#/components/progress)
53-
* [Rating](https://edcarroll.github.io/ng2-semantic-ui/#/components/rating)
54-
* [Search](https://edcarroll.github.io/ng2-semantic-ui/#/components/search)
55-
* [Select](https://edcarroll.github.io/ng2-semantic-ui/#/components/select)
56-
* [Sidebar](https://edcarroll.github.io/ng2-semantic-ui/#/components/sidebar)
57-
* [Tabs](https://edcarroll.github.io/ng2-semantic-ui/#/components/tabs)
58-
* [Transition](https://edcarroll.github.io/ng2-semantic-ui/#/components/transition)
46+
## Component Support
47+
48+
| Icon | Description |
49+
|-------------------------|-------------------------------------------------------------------------------------|
50+
| :white_check_mark: | Component supported by ng2-semantic-ui. |
51+
| :rocket: | Semantic UI plugin supported by ng2-semantic-ui (not in Semantic UI Core). |
52+
| :ballot_box_with_check: | Component supported natively by [Semantic UI](https://semantic-ui.com/) (CSS only). |
53+
| :x: | Component currently unavailable. |
54+
| :no_entry_sign: | Component not applicable to Angular. |
55+
56+
| Elements | Collections | Views | Modules | Behaviors |
57+
|------------------------------------|------------------------------------|------------------------------------------|-----------------------------------|-------------------------------------|
58+
| :ballot_box_with_check: Button | :ballot_box_with_check: Breadcrumb | :ballot_box_with_check: Advertisment | :white_check_mark: Accordion | :no_entry_sign: API |
59+
| :ballot_box_with_check: Container | :ballot_box_with_check: Form | :ballot_box_with_check: Card | :white_check_mark: Checkbox | :no_entry_sign: Form Validation |
60+
| :ballot_box_with_check: Divider | :ballot_box_with_check: Grid | :ballot_box_with_check: Comment | :rocket: Collapse | :rocket: Localization |
61+
| :ballot_box_with_check: Flag | :ballot_box_with_check: Menu | :ballot_box_with_check: Feed | :rocket: Datepicker | :x: Visibiltiy |
62+
| :ballot_box_with_check: Header | :white_check_mark: Message | :ballot_box_with_check: Item | :white_check_mark: Dimmer | |
63+
| :ballot_box_with_check: Icon | :rocket: Pagination | :ballot_box_with_check: Statistic | :white_check_mark: Dropdown | |
64+
| :ballot_box_with_check: Image | :ballot_box_with_check: Table | | :x: Embed | |
65+
| :ballot_box_with_check: Input | | | :white_check_mark: Modal | |
66+
| :ballot_box_with_check: Label | | | :white_check_mark: Popup | |
67+
| :ballot_box_with_check: List | | | :white_check_mark: Progress | |
68+
| :ballot_box_with_check: Loader | | | :white_check_mark: Rating | |
69+
| :ballot_box_with_check: Rail | | | :white_check_mark: Search | |
70+
| :ballot_box_with_check: Reveal | | | :x: Shape | |
71+
| :ballot_box_with_check: Segment | | | :white_check_mark: Sidebar | |
72+
| :ballot_box_with_check: Step | | | :x: Sticky | |
73+
| | | | :white_check_mark: Tab | |
74+
| | | | :white_check_mark: Transition | |
5975

6076
## Want to help?
6177

@@ -75,6 +91,25 @@ To run the demo app (you must have [Angular-CLI](https://github.com/angular/angu
7591
$ ng serve
7692
```
7793

94+
## Testing
95+
96+
To run the unit tests suite:
97+
```bash
98+
$ npm run test
99+
```
100+
101+
To run the unit test suit in watch mode (the whole suite is re-executed every code/test change):
102+
```bash
103+
$ npm run test:w
104+
```
105+
106+
To generate code coverage report:
107+
```bash
108+
$ npm run test:cov
109+
```
110+
this will generate a folder `coverage` with the HTML report
111+
112+
78113
## License
79114

80115
MIT © [Edward Carroll](https://github.com/edcarroll)

angular-cli.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"project": {
3-
"version": "1.0.0-beta.31",
3+
"version": "1.0.0",
44
"name": "ng2-semantic-ui"
55
},
66
"apps": [
@@ -13,7 +13,9 @@
1313
],
1414
"index": "index.html",
1515
"main": "main.ts",
16+
"test": "../../src/test.ts",
1617
"tsconfig": "tsconfig.json",
18+
"testTsconfig": "../../src/tsconfig.spec.json",
1719
"prefix": "demo",
1820
"mobile": false,
1921
"styles": [
@@ -37,7 +39,7 @@
3739
},
3840
"test": {
3941
"karma": {
40-
"config": "./karma.conf.js"
42+
"config": "./src/karma.conf.ts"
4143
}
4244
},
4345
"defaults": {

components/checkbox/radiobutton.ts

Lines changed: 0 additions & 93 deletions
This file was deleted.

components/index.ts

Lines changed: 0 additions & 17 deletions
This file was deleted.

components/modal/modal-template.ts

Lines changed: 0 additions & 5 deletions
This file was deleted.

components/search/search.module.ts

Lines changed: 0 additions & 26 deletions
This file was deleted.

0 commit comments

Comments
 (0)