Skip to content

Commit e087322

Browse files
committed
Renamed popup options
Renamed `inverted` to `isInverted` Renamed `basic` to `isBasic`
1 parent 8f73d1f commit e087322

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed

components/popup/popup-config.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ export interface IPopupConfig {
1919
template?:TemplateRef<TemplateRefContext<IPopup>>;
2020
placement?:PositioningPlacement;
2121
trigger?:PopupTrigger;
22-
inverted?:boolean;
22+
isInverted?:boolean;
2323
delay?:number;
24-
basic?:boolean;
24+
isBasic?:boolean;
2525
transition?:string;
2626
transitionDuration?:number;
2727
}
@@ -32,18 +32,18 @@ export class PopupConfig implements IPopupConfig {
3232
public template:TemplateRef<TemplateRefContext<IPopup>>;
3333
public placement:PositioningPlacement;
3434
public trigger:PopupTrigger;
35-
public inverted:boolean;
35+
public isInverted:boolean;
3636
public delay:number;
37-
public basic:boolean;
37+
public isBasic:boolean;
3838
public transition:string;
3939
public transitionDuration:number;
4040

4141
constructor(defaults:IPopupConfig = {}) {
4242
this.placement = PositioningPlacement.TopLeft;
4343
this.trigger = PopupTrigger.Hover;
44-
this.inverted = false;
44+
this.isInverted = false;
4545
this.delay = 0;
46-
this.basic = false;
46+
this.isBasic = false;
4747
this.transition = "scale";
4848
this.transitionDuration = 200;
4949

components/popup/popup.directive.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,12 @@ export class SuiPopupDirective implements IPopup {
3535

3636
@Input()
3737
public set popupInverted(inverted:boolean) {
38-
this.config.inverted = parseBooleanAttribute(inverted);
38+
this.config.isInverted = parseBooleanAttribute(inverted);
3939
}
4040

4141
@Input()
4242
public set popupBasic(basic:boolean) {
43-
this.config.basic = parseBooleanAttribute(basic);
43+
this.config.isBasic = parseBooleanAttribute(basic);
4444
}
4545

4646
@Input()

components/popup/popup.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@ import Popper from "popper.js";
1010
@Component({
1111
selector: 'sui-popup',
1212
template: `
13-
<div class="ui popup" [class.inverted]="config.inverted" [class.basic]="config.basic" [suiTransition]="transitionController" [attr.direction]="direction" #container>
13+
<div class="ui popup" [class.inverted]="config.isInverted" [class.basic]="config.isBasic" [suiTransition]="transitionController" [attr.direction]="direction" #container>
1414
<ng-container *ngIf="!config.template">
1515
<div class="header" *ngIf="config.header">{{ config.header }}</div>
1616
<div class="content">{{ config.text }}</div>
1717
</ng-container>
1818
<div #templateSibling></div>
19-
<sui-popup-arrow *ngIf="!config.basic" [placement]="_positioningService.placement" [inverted]="config.inverted"></sui-popup-arrow>
19+
<sui-popup-arrow *ngIf="!config.isBasic" [placement]="_positioningService.placement" [inverted]="config.isInverted"></sui-popup-arrow>
2020
</div>
2121
`,
2222
styles: [`

demo/src/app/app.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {SuiPopupConfig} from '../../../components/popup/popup.service';
88
})
99
export class AppComponent {
1010
constructor(popupConfig:SuiPopupConfig) {
11-
popupConfig.inverted = true;
11+
popupConfig.isInverted = true;
1212
popupConfig.delay = 300;
1313
}
1414
}

demo/src/app/pages/popup/popup.page.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ import {SuiPopupConfig} from "ng2-semantic-ui";
156156
@Component({})
157157
export class MyComponent {
158158
constructor(globalConfig:SuiPopupConfig) {
159-
globalConfig.inverted = true;
159+
globalConfig.isInverted = true;
160160
globalConfig.delay = 300;
161161
}
162162
}

0 commit comments

Comments
 (0)