Skip to content

Commit 07785fb

Browse files
authored
Remove collector's sanity check from pre-main workflow (redhat-best-practices-for-k8s#2420)
1 parent dd59261 commit 07785fb

File tree

1 file changed

+0
-46
lines changed

1 file changed

+0
-46
lines changed

.github/workflows/pre-main.yaml

Lines changed: 0 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -309,13 +309,6 @@ jobs:
309309
env:
310310
IMAGE_TAG: ${CERTSUITE_IMAGE_TAG}
311311

312-
# Prepare collector to be used when running smoke tests
313-
- name: Check out `Collector`
314-
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
315-
with:
316-
repository: redhat-best-practices-for-k8s/collector
317-
path: collector
318-
319312
# Clean up unused container image layers. We need to filter out a possible error return code
320313
# from docker with "|| true" as some images might still be used by running kind containers and
321314
# will not be removed.
@@ -333,29 +326,6 @@ jobs:
333326
cp config/*.yml $CERTSUITE_CONFIG_DIR
334327
shell: bash
335328

336-
- name: Get Collector's CI credentials
337-
run: |
338-
echo "collector_ciuser=ciuser_${{ github.run_id }}" >> $GITHUB_OUTPUT
339-
echo "collector_cipassword=cipassword" >> $GITHUB_OUTPUT
340-
id: set_collector_ci_creds
341-
342-
- name: Update Collector's CI credentials and Print username
343-
run: |
344-
echo Collector CI username: ${{ steps.set_collector_ci_creds.outputs.collector_ciuser }}
345-
echo "COLLECTOR_CIUSER=${{ steps.set_collector_ci_creds.outputs.collector_ciuser }}" >> $GITHUB_ENV
346-
echo "COLLECTOR_CIPASSWORD=${{ steps.set_collector_ci_creds.outputs.collector_cipassword }}" >> $GITHUB_ENV
347-
348-
- name: Ensure COLLECTOR_CIUSER and COLLECTOR_CIPASSWORD are set
349-
run: '[[ -n "$COLLECTOR_CIUSER" ]] && [[ -n "$COLLECTOR_CIPASSWORD" ]]'
350-
351-
- name: Modify Certsuite config with CI collector credentials
352-
run: |
353-
sed -i\
354-
-e '/executedBy/s/""/"CI"/g' \
355-
-e '/partnerName/s/""/"${{ env.COLLECTOR_CIUSER }}"/g' \
356-
-e '/collectorAppPassword/s/""/"${{ env.COLLECTOR_CIPASSWORD }}"/g' \
357-
$CERTSUITE_CONFIG_DIR/certsuite_config.yml
358-
359329
- name: 'Test: Run without any TS, just get diagnostic information'
360330
run: |
361331
docker run --rm --network host \
@@ -386,22 +356,6 @@ jobs:
386356
--kubeconfig=/usr/certsuite/config/kubeconfig \
387357
--label-filter="${SMOKE_TESTS_LABELS_FILTER}"
388358
389-
# - name: Run sanity check on collector
390-
# id: collector_sanity_check
391-
# uses: ./collector/.github/actions/run-sanity-check
392-
# with:
393-
# working_directory: collector
394-
# collector_username: ${COLLECTOR_CIUSER}
395-
# collector_password: ${COLLECTOR_CIPASSWORD}
396-
# continue-on-error: true
397-
398-
# - name: Send chat msg to dev team if collector's sanity check failed.
399-
# if: ${{ steps.collector_sanity_check.outcome == 'failure' }}
400-
# uses: ./.github/actions/slack-webhook-sender
401-
# with:
402-
# message: 'Collector sanity check has failed'
403-
# slack_webhook: '${{ secrets.SLACK_ALERT_WEBHOOK_URL }}'
404-
405359
- name: Upload container test results as an artifact
406360
uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
407361
if: always()

0 commit comments

Comments
 (0)