rename pushRingBuffer to processTasks

Author: a114j0y

orchagent/orch.cpp

@@ -335,16 +335,13 @@ void Consumer::execute()
     auto entries = std::make_shared<std::deque<KeyOpFieldsValuesTuple>>();
     getConsumerTable()->pops(*entries);
 
-    pushRingBuffer([=](){
+    processTasks([=](){
         addToSync(entries);
-    });
-
-    pushRingBuffer([=](){
         drain();
     });
 }
 
-void Executor::pushRingBuffer(AnyTask&& task)
+void Executor::processTasks(AnyTask&& task)
 {
     if (!gRingBuffer || !gRingBuffer->thread_created) 
     {

orchagent/orch.h

@@ -135,7 +135,7 @@ class Executor : public swss::Selectable
 
     Orch *getOrch() const { return m_orch; }
     static std::shared_ptr<RingBuffer> gRingBuffer;
-    void pushRingBuffer(AnyTask&& func);
+    void processTasks(AnyTask&& func);
 
 protected:
     swss::Selectable *m_selectable;

tests/mock_tests/orchdaemon_ut.cpp

@@ -141,18 +141,18 @@ namespace orchdaemon_test
         EXPECT_FALSE(gRingBuffer->serves("OTHER_TABLE"));
 
         int x = 0;
-        route_consumer->pushRingBuffer([&](){x=3;});
-        // verify `pushRingBuffer` is equivalent to executing the task immediately
+        route_consumer->processTasks([&](){x=3;});
+        // verify `processTasks` is equivalent to executing the task immediately
         EXPECT_TRUE(gRingBuffer->IsEmpty() && gRingBuffer->IsIdle() && !gRingBuffer->thread_created && x==3);
 
         gRingBuffer->thread_created = true; // set the flag to assume the ring thread is created (actually not)
 
-        // verify `pushRingBuffer` is equivalent to executing the task immediately when ring is empty and idle
-        other_consumer->pushRingBuffer([&](){x=4;});
+        // verify `processTasks` is equivalent to executing the task immediately when ring is empty and idle
+        other_consumer->processTasks([&](){x=4;});
         EXPECT_TRUE(gRingBuffer->IsEmpty() && gRingBuffer->IsIdle() && x==4);
 
-        route_consumer->pushRingBuffer([&](){x=5;});
-        // verify `pushRingBuffer` would not execute the task if thread_created is true
+        route_consumer->processTasks([&](){x=5;});
+        // verify `processTasks` would not execute the task if thread_created is true
         // it only pushes the task to the ring buffer, without executing it
         EXPECT_TRUE(!gRingBuffer->IsEmpty() && x==4);