Skip to content

Commit 1042eb3

Browse files
committed
Fix unsigned Windows release packaging and bump version to 2.1.5
1 parent 3f62ba7 commit 1042eb3

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

.github/workflows/release.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -167,8 +167,7 @@ jobs:
167167
runs-on: windows-latest
168168
needs: validate-tag
169169
env:
170-
WIN_CSC_LINK: ${{ secrets.WIN_CSC_LINK }}
171-
WIN_CSC_KEY_PASSWORD: ${{ secrets.WIN_CSC_KEY_PASSWORD }}
170+
WIN_SIGNING_AVAILABLE: ${{ secrets.WIN_CSC_LINK != '' }}
172171
steps:
173172
- name: Checkout repository
174173
uses: actions/checkout@v6
@@ -196,15 +195,15 @@ jobs:
196195

197196
# Build and sign for Windows
198197
- name: Package Windows (signed)
199-
if: ${{ env.WIN_CSC_LINK != '' }}
198+
if: ${{ env.WIN_SIGNING_AVAILABLE == 'true' }}
200199
run: npx electron-builder --win --x64 --publish never --config electron-builder.yml
201200
env:
202201
WIN_CSC_LINK: ${{ secrets.WIN_CSC_LINK }}
203202
WIN_CSC_KEY_PASSWORD: ${{ secrets.WIN_CSC_KEY_PASSWORD }}
204203

205204
# Build unsigned if no signing credentials
206205
- name: Package Windows (unsigned)
207-
if: ${{ env.WIN_CSC_LINK == '' }}
206+
if: ${{ env.WIN_SIGNING_AVAILABLE != 'true' }}
208207
run: npx electron-builder --win --x64 --publish never --config electron-builder.yml
209208
env:
210209
CSC_IDENTITY_AUTO_DISCOVERY: false

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "markupr",
3-
"version": "2.1.4",
3+
"version": "2.1.5",
44
"description": "AI-ready developer feedback capture tool with voice narration and intelligent screenshots",
55
"type": "module",
66
"main": "dist/main/index.mjs",

0 commit comments

Comments
 (0)