Adding labels to split StopWatch feature - replacing startNanoTime

Author: edelgadoh

src/main/java/org/apache/commons/lang3/time/StopWatch.java

@@ -17,7 +17,6 @@
 
 package org.apache.commons.lang3.time;
 
-import java.time.Clock;
 import java.time.Duration;
 import java.time.Instant;
 import java.util.ArrayList;
@@ -865,8 +864,11 @@ private void processSplits(TimeUnit timeUnit) {
         }
 
         for (int i = 0; i < splits.size() - 1; i++) {
-            final Duration duration = Duration.between(splits.get(i).getStartTime(), splits.get(i + 1).getStartTime());
-            splits.get(i).setDuration(timeUnit == TimeUnit.NANOSECONDS ? duration.toNanos() : duration.toMillis());
+            final long durationNanos = splits.get(i + 1).getStartNanoTime() - splits.get(i).getStartNanoTime();
+            final long duration = (timeUnit == TimeUnit.NANOSECONDS)
+                    ? durationNanos
+                    : TimeUnit.MILLISECONDS.convert(durationNanos, TimeUnit.NANOSECONDS);
+            splits.get(i).setDuration(duration);
         }
 
     }
@@ -931,9 +933,9 @@ private String getReport(TimeUnit timeUnit) {
     protected static class Split {
 
         /**
-         * The start time of this split
+         * The start nano time of this split
          */
-        private Instant startTime = Clock.systemUTC().instant();
+        private long startNanoTime = System.nanoTime();
 
         /**
          * The duration (time took) on this split
@@ -959,10 +961,10 @@ public Split(String label) {
          * Get the timestamp when this split was created
          * </p>
          *
-         * @return startTime
+         * @return startNanoTime
          */
-        public Instant getStartTime() {
-            return startTime;
+        public long getStartNanoTime() {
+            return startNanoTime;
         }
 
         /**

src/test/java/org/apache/commons/lang3/time/StopWatchTest.java

@@ -531,7 +531,7 @@ void testSplitsWithStringLabels() {
         assertEquals(splits.get(2).getLabel(), thirdLabel);
 
         // check duration
-        final int margin = 200;
+        final int margin = 50;
         assertEquals(firstSleepTime, splits.get(0).getDuration(), margin);
         assertEquals(secondSleepTime, splits.get(1).getDuration(), margin);
         assertEquals(thirdSleepTime, splits.get(2).getDuration(), margin);
@@ -578,7 +578,7 @@ void testSplitsWithIntLabels() {
         assertEquals(splits.get(2).getLabel(), String.valueOf(thirdLabel));
 
         // check duration
-        final int margin = 200;
+        final int margin = 50;
         assertEquals(firstSleepTime, splits.get(0).getDuration(), margin);
         assertEquals(secondSleepTime, splits.get(1).getDuration(), margin);
         assertEquals(thirdSleepTime, splits.get(2).getDuration(), margin);
@@ -612,7 +612,7 @@ void testNanoSplitsWithLabel() {
         assertEquals(2, splits.size());
 
         // check duration
-        final int margin = 200_000_000;
+        final int margin = 50_000_000;
         assertEquals(200_000_000, splits.get(0).getDuration(), margin);
         assertEquals(300_000_000, splits.get(1).getDuration(), margin);