chore: Generated Files.FileUploadRequest resource#1274
Open
osmanhadzic wants to merge 2 commits intoedgehog-device-manager:mainfrom
Open
chore: Generated Files.FileUploadRequest resource#1274osmanhadzic wants to merge 2 commits intoedgehog-device-manager:mainfrom
osmanhadzic wants to merge 2 commits intoedgehog-device-manager:mainfrom
Conversation
osmanhadzic
requested review from
OmarBrbutovic and
lusergit
and removed request for
OmarBrbutovic
osmanhadzic
force-pushed
the
feat/file-upload-request
branch
from
ab1f239 to
5b579cb
Compare
OmarBrbutovic
requested changes
Mar 9, 2026
Collaborator
OmarBrbutovic
left a comment
OmarBrbutovic
left a comment
There was a problem hiding this comment.
In general, I would suggest slowing down the merge of this PR. The overall implementation of the feature has been changing frequently, and it would be better to stabilize the approach first.
Please make sure to research and implement the backend logic, not just the Resource layer. Additionally, the required migrations are currently missing.
For reference on how to properly introduce a new resource in Edgehog, you can look at these PRs:
osmanhadzic
force-pushed
the
feat/file-upload-request
branch
4 times, most recently
from
d166ff8 to
be3f449
Compare
Generated the `Files.FileDownloadRequest` resource using the command ```bash mix ash.gen.resource Edgehog.Files.FileUploadRequest \\ --default-actions read,destroy \\ --uuid-v7-primary-key id \\ --attribute url:string:required:public \\ --attribute source:string:public \\ --attribute compression:string:public \\ --attribute progress_enabled:boolean:public \\ --attribute status:string:public \\ --attribute progress_percentage:integer:public \\ --attribute response_code:integer:public \\ --attribute response_message:string:public \\ --relationship belongs_to:device:Edgehog.Devices.Device:required:public \\ --timestamps \\ --extend postgres,graphql ```` Signed-off-by: Osman Hadzic <osman.hadzic@secomind.com>
Generated migrate and snapshots using command: ˛˛˛ bash mix ash.codegen create_files_upload_resource ˛˛˛ - Introduce `FileUploadRequest` module to handle file upload requests on Astarte devices. - Add changes for setting upload URLs and sending file upload requests. - Update `HandleTrigger` to process file upload events and update request statuses. - Add tests for file upload request processing and progress updates. Signed-off-by: Osman Hadzic <osman.hadzic@secomind.com>
osmanhadzic
force-pushed
the
feat/file-upload-request
branch
from
be3f449 to
f4f771c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated the
Files.FileDownloadRequestresource using the commandChange Title
Checklist
Further Comments (optional)
Screenshots / Demos (optional)