Hook into magit when making a commit

[slipset]

When making a commit, it would be super nice if eca could hook into magit, and basically provide me with the commit msg buffer where it had prefilled the commit msg.

[ericdallo]

That sounds like a good integration between eca and editor!
I'm wondering that the best place for that is use your idea @zikajk of separate the commit stuff from eca__shell_command and have a tool for that + a new tool for interact with the editor git integration, like magit.

@slipset I think we should start by aligning what user expects to happen, for example, only when eca commits you intend to do that, or you expect to send prompts like prepare commit or something that would open the magit interface.

[zikajk]

I don't see how normal hooks can be used for this. In this case running emacs client must communicate with the EMacs. Or am I missing something?

[ericdallo]

@zikajk I don't think OP meant the "hooks" feature 😅, he just want to make eca-emacs integrate with magit somehow when eca is commiting or user asks for it

[zikajk]

I misunderstood what you meant by my idea, my bad ;-).
But I don't see how any tool could work with that. We still would have to interpret what it does, then pause Eca, then let user do his work in magit, interpret actions there and update tool output and just then continue. Seems like quite complex idea that might be expanded to smth like client hooks where you can do llm <-> ide communication.

[slipset]

I'm super happy that you're even considering these issues. Please do close if you think they're out of scope or infeasible.

[ericdallo]

@zikajk I think the thing is that magit (or any editor git like interface) is a powerful tool in editors, after we migrate the git stuff from shell_command -> another eca tool, this might be easier to achieve, for example, we could have a specific tool to present_git_commit or something that would just say to editor open magit or something

[zikajk]

Edit: I missed the second part. Yeah, present_git_commit would work :-).

[ericdallo]

@slipset what's your expectation as a user? when you would expect to magic show up? after what actions or events?

[slipset]

I think I'd be super happy with typing /commit which would (ma)git add all edited changes, and open the window you get with cc in magit, and populate the message with something that the model wrote, and then for me to press C-c C-c to accept that commit

[ericdallo]

Sounds good, @zikajk I think we could have a built-in command /commit which we could detail to use a new tool eca__prepare_commit, this tool would receive a arg commit_message and then call the editor to open the interface with that message, what you think?