Merge pull request #2 from editor-code-assistant/fix-gh-rl

Make authenticated GitHub API request

Author: CsBigDataHub

README.md

@@ -32,6 +32,21 @@ mise use -g [email protected]
 eca --version
 ```
 
+## GitHub API Rate Limiting
+
+This plugin fetches ECA releases from GitHub. To avoid rate limiting issues, you can optionally set a GitHub token:
+
+```bash
+# Set one of these environment variables:
+export GITHUB_TOKEN="your_token_here"
+# or
+export GH_TOKEN="your_token_here"
+# or
+export GITHUB_API_TOKEN="your_token_here"
+```
+
+You can create a personal access token at https://github.com/settings/tokens (no special permissions needed for public repositories).
+
 ## Usage
 
 After installation, you can use ECA with your preferred editor:

hooks/available.lua

@@ -1,11 +1,13 @@
 -- hooks/available.lua
 function PLUGIN:Available(ctx)
-    local http = require("http")
+    local helper = require("helper")
     local json = require("json")
-    local resp, err = http.get({url = "https://api.github.com/repos/editor-code-assistant/eca/releases"})
-    if err or resp.status_code ~= 200 then
-        error("Failed to fetch releases: " .. (err or resp.status_code))
+
+    local resp, err = helper.github_request("https://api.github.com/repos/editor-code-assistant/eca/releases")
+    if err then
+        error("Failed to fetch releases: " .. err)
     end
+
     local releases = json.decode(resp.body)
     local result = {}
     for i, r in ipairs(releases) do

hooks/pre_install.lua

@@ -1,31 +1,11 @@
 -- hooks/pre_install.lua
 function PLUGIN:PreInstall(ctx)
     local version = ctx.version
-    local http = require("http")
+    local helper = require("helper")
 
-    -- Normalize architecture
-    local arch = RUNTIME.archType:lower()
-    local arch_token
-    if arch == "amd64" or arch == "x86_64" then
-        arch_token = "amd64"
-    elseif arch == "arm64" or arch == "aarch64" then
-        arch_token = "aarch64"
-    else
-        error("Unsupported architecture: " .. RUNTIME.archType)
-    end
-
-    -- Normalize OS
-    local os_l = RUNTIME.osType:lower()
-    local os_token
-    if os_l:find("windows") then
-        os_token = "windows"
-    elseif os_l:find("darwin") then
-        os_token = "macos"
-    elseif os_l:find("linux") then
-        os_token = "linux"
-    else
-        error("Unsupported OS: " .. RUNTIME.osType)
-    end
+    -- Get normalized OS and architecture
+    local os_token = helper.get_os()
+    local arch_token = helper.get_arch()
 
     -- Construct filename (dynamic builds)
     local filename = string.format("eca-native-%s-%s.zip", os_token, arch_token)
@@ -34,8 +14,8 @@ function PLUGIN:PreInstall(ctx)
     -- Fetch checksum
     local sha256
     do
-        local resp, err = http.get({url = url .. ".sha256"})
-        if not err and resp.status_code == 200 then
+        local resp, err = helper.github_request(url .. ".sha256")
+        if not err and resp then
             sha256 = resp.body:match("^(%w+)")
         end
     end

lib/helper.lua

@@ -25,4 +25,45 @@ end
 function M.get_platform()
     return M.get_os() .. "-" .. M.get_arch()
 end
+
+-- Make authenticated GitHub API request
+function M.github_request(url)
+    local http = require("http")
+    local headers = {}
+
+    -- Try to get GitHub token from environment
+    local token = os.getenv("GITHUB_TOKEN") or os.getenv("GITHUB_API_TOKEN") or os.getenv("GH_TOKEN")
+    if token then
+        headers["Authorization"] = "Bearer " .. token
+    end
+
+    -- Set User-Agent (required by GitHub API)
+    headers["User-Agent"] = "mise-vfox-eca-plugin"
+
+    local resp, err = http.get({
+        url = url,
+        headers = headers
+    })
+
+    if err then
+        return nil, "HTTP request failed: " .. err
+    end
+
+    if resp.status_code == 403 then
+        local err_msg = "GitHub API rate limit exceeded. "
+        if not token then
+            err_msg = err_msg .. "Please set GITHUB_TOKEN environment variable to authenticate and increase rate limit."
+        else
+            err_msg = err_msg .. "Authenticated request failed with 403."
+        end
+        return nil, err_msg
+    end
+
+    if resp.status_code ~= 200 then
+        return nil, "GitHub API returned status code: " .. resp.status_code
+    end
+
+    return resp, nil
+end
+
 return M