simplify log opts

Author: tomgeorge

lua/eca/commands.lua

@@ -194,7 +194,7 @@ function M.setup()
     elseif subcommand == "log_path" then
       local log_path = Logger.get_log_path()
       if log_path then
-        Utils.info("ECA log file: " .. log_path, { nofity_only = true })
+        Utils.info("ECA log file: " .. log_path, { notify = true })
       else
         Utils.info("File logging is disabled")
       end

lua/eca/logger.lua

@@ -112,7 +112,7 @@ end
 --- Main logging function
 ---@param message string
 ---@param level integer
----@param opts? {title?: string, once?: boolean, file_only?: boolean, notify_only?: boolean}
+---@param opts? {title?: string, once?: boolean, file?: boolean, notify?: boolean}
 function M.log(message, level, opts)
   opts = opts or {}
 
@@ -126,16 +126,14 @@ function M.log(message, level, opts)
     return
   end
 
-  -- Console notification
-  if config.log.notify and not opts.file_only then
+  if opts.notify then
     vim.notify(message, level, {
       title = opts.title or "ECA",
       once = opts.once,
     })
   end
 
-  -- File logging
-  if config.log.file and not opts.notify_only then
+  if opts.file then
     local log_path = resolve_log_path(config.log.file)
     if log_path then
       -- Ensure parent directory exists
@@ -161,28 +159,28 @@ end
 
 --- Log debug message
 ---@param message string
----@param opts? {title?: string, once?: boolean, file_only?: boolean, notify_only?: boolean}
+---@param opts? {title?: string, once?: boolean, file?: boolean, notify?: boolean}
 function M.debug(message, opts)
   M.log(message, vim.log.levels.DEBUG, opts)
 end
 
 --- Log info message
 ---@param message string
----@param opts? {title?: string, once?: boolean, file_only?: boolean, notify_only?: boolean}
+---@param opts? {title?: string, once?: boolean, file?: boolean, notify?: boolean}
 function M.info(message, opts)
   M.log(message, vim.log.levels.INFO, opts)
 end
 
 --- Log warn message
 ---@param message string
----@param opts? {title?: string, once?: boolean, file_only?: boolean, notify_only?: boolean}
+---@param opts? {title?: string, once?: boolean, file?: boolean, notify?: boolean}
 function M.warn(message, opts)
   M.log(message, vim.log.levels.WARN, opts)
 end
 
 --- Log error message
 ---@param message string
----@param opts? {title?: string, once?: boolean, file_only?: boolean, notify_only?: boolean}
+---@param opts? {title?: string, once?: boolean, file?: boolean, notify?: boolean}
 function M.error(message, opts)
   M.log(message, vim.log.levels.ERROR, opts)
 end

lua/eca/server.lua

@@ -90,9 +90,10 @@ function M:_log_to_file(level, message)
     vim_level = vim.log.levels.ERROR
   end
 
-  -- Log with file_only to avoid duplicate notifications
+  -- Log to file only to avoid duplicate notifications
   Logger.log(message, vim_level, { 
-    file_only = true,
+    file = true,
+    notify = false,
     title = "SERVER"
   })
 end

lua/eca/utils.lua

@@ -8,7 +8,7 @@ local CONSTANTS = {
 }
 
 ---@param msg string
----@param opts? {title?: string, once?: boolean, file_only?: boolean, notify_only?: boolean}
+---@param opts? {title?: string, once?: boolean, file?: boolean, notify?: boolean}
 function M.debug(msg, opts)
   opts = opts or {}
   local Config = require("eca.config")
@@ -19,23 +19,23 @@ function M.debug(msg, opts)
 end
 
 ---@param msg string  
----@param opts? {title?: string, once?: boolean, file_only?: boolean, notify_only?: boolean}
+---@param opts? {title?: string, once?: boolean, file?: boolean, notify?: boolean}
 function M.info(msg, opts)
   opts = opts or {}
   local Logger = require("eca.logger")
   Logger.info(msg, opts)
 end
 
 ---@param msg string
----@param opts? {title?: string, once?: boolean, file_only?: boolean, notify_only?: boolean}
+---@param opts? {title?: string, once?: boolean, file?: boolean, notify?: boolean}
 function M.warn(msg, opts)
   opts = opts or {}
   local Logger = require("eca.logger")
   Logger.warn(msg, opts)
 end
 
 ---@param msg string
----@param opts? {title?: string, once?: boolean, file_only?: boolean, notify_only?: boolean}
+---@param opts? {title?: string, once?: boolean, file?: boolean, notify?: boolean}
 function M.error(msg, opts)
   opts = opts or {}
   local Logger = require("eca.logger")