add another test case for inexistent server path and other small fixes

Author: joaopluigi

lua/eca/path_finder.lua

@@ -187,12 +187,10 @@ end
 function M:find(custom_path)
   -- Check for custom server path first
   if custom_path and custom_path:gsub("%s+", "") ~= "" then
-    if Utils.file_exists(custom_path) then
-      Logger.debug("Using custom server path: " .. custom_path)
-      return custom_path
-    else
-      Logger.notify("Custom server path does not exist: " .. custom_path, vim.log.levels.WARN)
+    if not Utils.file_exists(custom_path) then
+      error("Custom server path does not exist: " .. custom_path)
     end
+    return custom_path
   end
 
   local server_path = self:_get_extension_server_path()

lua/eca/server.lua

@@ -110,7 +110,7 @@ function M:start(opts)
     nvim_exe = "nvim"
   end
 
-  local lua_cmd = string.format("lua ServerPath.run(%s)", Utils.lua_quote(Config.server_path) or "")
+  local lua_cmd = string.format("lua ServerPath.run(%s)", Utils.lua_quote(Config.server_path or ""))
 
   local cmd = { nvim_exe, "--headless", "--noplugin", "--clean", "-u", script_path, "-c", lua_cmd }
 
@@ -253,12 +253,6 @@ end
 ---@param params table
 ---@param callback? function
 function M:send_request(method, params, callback)
-  if not self:is_running() then
-    Logger.error("ECA server is not running")
-    if callback then
-      callback("Server not running", nil)
-    end
-  end
   local id = self:get_next_id()
   local message = {
     jsonrpc = "2.0",
@@ -272,6 +266,15 @@ function M:send_request(method, params, callback)
 
   local json = vim.json.encode(message)
   table.insert(self.messages, { content = json, content_length = #json })
+
+  if not self:is_running() then
+    Logger.error("ECA server is not running")
+    if callback then
+      callback("Server not running", nil)
+    end
+    return
+  end
+
   local content = string.format("Content-Length: %d\r\n\r\n%s", #json, json)
   self.process:write(content)
 end

tests/test_server_integration.lua

@@ -63,4 +63,20 @@ T["server"]["start without initialize"] = function()
   eq(child.lua_get("_G.server.initialized"), false)
 end
 
+T["server"]["start with inexistent path"] = function()
+  child.lua([[
+    Config = require("eca.config")
+    Config.setup({ server_path = "non-existing-path" } )
+    _G.server:start()
+  ]])
+  child.lua([[
+    _G.server_started = vim.wait(1000, function()
+      return _G.server and _G.server:is_running()
+    end, 100)
+  ]])
+  eq(string.find(child.lua_get("_G.notifications[1].message"), "non-existing-path", 1 , true) ~= nil, true)
+  eq(child.lua_get("_G.server_started"), false)
+  eq(child.lua_get("_G.server.initialized"), false)
+end
+
 return T