Fix completion error handling

Author: ericdallo

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Unreleased
 
 - Improve chat title generation.
+- Fix completion error handling.
 
 ## 0.73.0
 

src/eca/handlers.clj

@@ -108,7 +108,7 @@
 
 (defn chat-query-commands [{:keys [db* config metrics]} params]
   (metrics/task metrics :eca/chat-query-commands
-                (f.chat/query-commands params db* config)))
+    (f.chat/query-commands params db* config)))
 
 (defn chat-tool-call-approve [{:keys [messenger db* metrics]} params]
   (metrics/task metrics :eca/chat-tool-call-approve

src/eca/llm_api.clj

@@ -72,7 +72,8 @@
 (defn ^:private prompt!
   [{:keys [provider model model-capabilities instructions user-messages config
            on-message-received on-error on-prepare-tool-call on-tools-called on-reason on-usage-updated
-           past-messages tools provider-auth sync?]}]
+           past-messages tools provider-auth sync?]
+    :or {on-error identity}}]
   (let [real-model (real-model-name model model-capabilities)
         tools (when (:tools model-capabilities)
                 (mapv tool->llm-tool tools))
@@ -274,5 +275,4 @@
     :past-messages past-messages
     :user-messages (or user-messages
                        [{:role "user" :content [{:type :text :text prompt}]}])
-    :config config
-    :on-error identity}))
+    :config config}))

src/eca/llm_providers/openai.clj

@@ -36,7 +36,7 @@
                    on-error
                    (fn [error-data]
                      (llm-util/log-response logger-tag rid "response-error" body)
-                     (reset! response* error-data)))]
+                     (reset! response* {:error error-data})))]
     (llm-util/log-request logger-tag rid url body)
     @(http/post
       url