Modified tests to check for toolCallRejected params.

The tests now check to see whether the parameters to toolCallRejected
are populated as much as possible.

Author: bombaywalla

test/eca/features/chat_tool_call_state_test.clj

@@ -601,7 +601,14 @@
             "Expected system message to contain 'stopped' text")
 
         (is (< 0 (count tool-reject-messages))
-            "Expected at least one toolCallRejected notification to be sent for active tool calls")))))
+            "Expected at least one toolCallRejected notification to be sent for active tool calls")
+
+        (is (every? (comp :id :content) tool-reject-messages)
+            "Expected every toolCallRejected message to have an :id")
+        (is (every? (comp :name :content) tool-reject-messages)
+            "Expected every toolCallRejected message to have a :name")
+        (is (every? (comp :origin :content) tool-reject-messages)
+            "Expected every toolCallRejected message to have an :origin")))))
 
 (deftest test-stop-prompt-message-count
   ;; Test that stop-prompt sends appropriate number of messages
@@ -630,21 +637,38 @@
     (h/reset-components!)
     (let [db* (h/db*)
           chat-id "test-chat"
-          chat-ctx {:chat-id chat-id :request-id "req-123" :messenger (h/messenger)}]
+          tool-call-id "tool-call-1"
+          chat-ctx {:chat-id chat-id :request-id "req-123" :messenger (h/messenger)}
+          approved?* (promise)]
 
       (swap! db* assoc-in [:chats chat-id]
              {:status :running
               :current-request-id "req-123"})
 
-      (#'f.chat/transition-tool-call! db* chat-ctx "tool-1" :tool-prepare
+      (#'f.chat/transition-tool-call! db* chat-ctx tool-call-id :tool-prepare
                                       {:name "list_files" :origin "filesystem" :arguments-text "{}"})
-
+      (#'f.chat/transition-tool-call! db* chat-ctx tool-call-id :tool-run
+                                      {:approved?* approved?*
+                                       :name "list_files"
+                                       :origin "filesystem"
+                                       :arguments {"id" 123 "value" 42}})
       (f.chat/prompt-stop {:chat-id chat-id} db* (h/messenger))
+      (when-not @approved?*
+        (#'f.chat/transition-tool-call! db* chat-ctx tool-call-id :send-reject
+                                        {:approved?* approved?*
+                                         :name "list_files"
+                                         :origin "filesystem"
+                                         :arguments {"id" 123 "value" 42}}))
 
       (let [chat-messages (:chat-content-received (h/messages))
-            message-types (map #(get-in % [:content :type]) chat-messages)]
-        (is (some #{:toolCallRejected} message-types)
-            "Expected toolCallRejected notifications when stopping with active tool calls")))))
+            tool-call-rejected-messages (filter #(= :toolCallRejected (get-in % [:content :type]))
+                                                chat-messages)]
+
+        (is (< 0 (count tool-call-rejected-messages))
+            "Expected toolCallRejected notifications when stopping with active tool calls")
+
+        (is (some #(get-in % [:content :arguments] %) tool-call-rejected-messages)
+            "Expected at least one toolCallRejected message to include non-nil :arguments")))))
 
 (deftest test-stop-prompt-with-non-running-chat
   ;; Test stop-prompt behavior when chat is not running.