Support manual approval for specific tools.

Fixes #44

Author: ericdallo

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+- Support manual approval for specific tools. #44
+
 ## 0.25.0
 
 - Improve plan-mode to do file changes with diffs.

docs/configuration.md

@@ -205,7 +205,7 @@ interface Config {
     };
     disabledTools: string[],
     toolCall?: {
-      manualApproval?: boolean,
+      manualApproval?: boolean | string[], // manual approve all tools or the specified tools
     };
     mcpTimeoutSeconds: number;
     mcpServers: {[key: string]: {
@@ -255,7 +255,7 @@ interface Config {
                             "excludeCommands": []}},
   "disabledTools": [],
   "toolCall": {
-    "manualApproval": false,
+    "manualApproval": null,
   },
   "mcpTimeoutSeconds" : 10,
   "mcpServers" : [],

src/eca/features/chat.clj

@@ -107,7 +107,6 @@
                                      :state :running
                                      :text "Parsing given context"}))
   (let [db @db*
-        manual-approval? (get-in config [:toolCall :manualApproval] false)
         all-models (models/all)
         provider (get-in all-models [model :provider])
         rules (f.rules/all config (:workspace-folders db))
@@ -175,7 +174,7 @@
                                                :origin (tool-name->origin name all-tools)
                                                :arguments-text (get-in @tool-call-by-id* [id :args])
                                                :id id
-                                               :manual-approval manual-approval?}
+                                               :manual-approval (f.tools/manual-approval? name config)}
                                               :summary (f.tools/tool-call-summary all-tools name nil))))
       :on-tools-called (fn [tool-calls]
                          (assert-chat-not-stopped! chat-ctx)
@@ -188,7 +187,8 @@
                                         (let [approved?* (promise)
                                               details (f.tools/get-tool-call-details name arguments)
                                               summary (f.tools/tool-call-summary all-tools name arguments)
-                                              origin (tool-name->origin name all-tools)]
+                                              origin (tool-name->origin name all-tools)
+                                              manual-approval? (f.tools/manual-approval? name config)]
                                          ;; Inform UI the tool is about to run and store approval promise
                                           (send-content! chat-ctx :assistant
                                                          (assoc-some

src/eca/features/tools.clj

@@ -112,6 +112,15 @@
                                                                         (assoc :type :mcp)
                                                                         (update :tools #(mapv with-tool-status %)))))})))
 
+(defn manual-approval? [name config]
+  (let [manual-approval? (get-in config [:toolCall :manualApproval] nil)]
+    (logger/info manual-approval?
+                 (coll? manual-approval?)
+                 name)
+    (if (coll? manual-approval?)
+      (some #(= name (str %)) manual-approval?)
+      manual-approval?)))
+
 (defn tool-call-summary [all-tools name args]
   (when-let [summary-fn (:summary-fn (first (filter #(= name (:name %))
                                                     all-tools)))]