Send as much information as possible with toolCallRejected.

In order to do that, we have to store the necessary information in the
tool call state, as early as possible.  In general, however, the
arguments to the tool call are not available until the :tool-run
event, so the recepients of toolCallRejected have to be able to handle
a null value of the arguments.

Replaced the :init-decision-reason action by the :init-tool-call-state
actions which initializes other aspects of the tool call as well.

Added a :init-arguments action to initialize the arguments to the tool
call when they are known during the :tool-run event.

Added comments specifying that all :send-* actions should typically be
last, and that the status is updated before any actions are run.

Author: bombaywalla

src/eca/features/chat.clj

@@ -86,7 +86,8 @@
    - promise init & delivery
    - logging/metrics
 
-   Note: all actions are run in the order specified.
+   Note: all actions are run in the order specified.  So, generally, the :send-* actions should be last.
+   Note: The :status is updated before any actions are run, so the actions have the latest :status.
 
    Note: all choices (i.e. conditionals) have to be made in code and result
    in different events sent to the state machine.
@@ -95,15 +96,15 @@
   {;; Note: transition-tool-call! treats no existing state as :initial state
    [:initial :tool-prepare]
    {:status :preparing
-    :actions [:send-toolCallPrepare :init-decision-reason]}
+    :actions [:init-tool-call-state :send-toolCallPrepare]}
 
    [:preparing :tool-prepare]
    {:status :preparing
     :actions [:send-toolCallPrepare]} ; Multiple prepares allowed
 
    [:preparing :tool-run]
    {:status :check-approval
-    :actions [:init-approval-promise :send-toolCallRun]}
+    :actions [:init-arguments :init-approval-promise :send-toolCallRun]}
    ;; TODO: What happens if the promise is created, but no deref happens since the call is stopped?
 
    [:check-approval :approval-ask]
@@ -246,10 +247,21 @@
     (deliver (get-in @db* [:chats (:chat-id chat-ctx) :tool-calls tool-call-id :approved?*])
              true)
 
-    :init-decision-reason
-    (swap! db* assoc-in [:chats (:chat-id chat-ctx) :tool-calls tool-call-id :decision-reason]
-           {:reason {:code :none
-                     :text "No reason"}})
+    :init-tool-call-state
+    (swap! db* assoc-in [:chats (:chat-id chat-ctx) :tool-calls tool-call-id]
+           {;; :status is initialized by the state transition machinery
+            ;; :approval* is initialized by the :init-approval-promise action
+            ;; :arguments is initialized by the :init-arguments action
+            ;; :start-time is initialized by the :set-start-time action
+            :name (:name event-data)
+            :arguments (:arguments event-data)
+            :origin (:origin event-data)
+            :decision-reason {:code :none
+                              :text "No reason"}})
+
+    :init-arguments
+    (swap! db* assoc-in [:chats (:chat-id chat-ctx) :tool-calls tool-call-id]
+           :arguments (:arguments event-data))
 
     :set-decision-reason
     (swap! db* assoc-in [:chats (:chat-id chat-ctx) :tool-calls tool-call-id :decision-reason]