Fix args streaming for toolCallPrepare

Author: ericdallo

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+- Fix args streaming in toolCallPrepare to not repeat the args. https://github.com/editor-code-assistant/eca-nvim/issues/28
+
 ## 0.29.0
 
 - Add editor tools to retrieve information like diagnostics. #56

docs/protocol.md

@@ -547,6 +547,8 @@ interface UsageContent {
 
 /**
  * Tool call that LLM is preparing to execute.
+ * This will be sent multiple times for same tool id for each time LLM outputs 
+ * a part of the arg, so clients should append the arguments to UI.
  */
 interface ToolCallPrepareContent {
     type: 'toolCallPrepare';
@@ -587,7 +589,7 @@ interface ToolCallPrepareContent {
 }
 
 /**
- * Tool call final request that LLM may trigger.
+ * Tool call final request that LLM may trigger, sent once per id.
  */
 interface ToolCallRunContent {
     type: 'toolCallRun';
@@ -628,7 +630,7 @@ interface ToolCallRunContent {
 }
 
 /**
- * Tool call result that LLM trigerred and was executed already.
+ * Tool call result that LLM trigerred and was executed already, sent once per id.
  */
 interface ToolCalledContent {
     type: 'toolCalled';
@@ -683,6 +685,9 @@ interface ToolCalledContent {
     details?: ToolCallDetails;
 }
 
+/**
+ * Tool call rejected, sent once per id.
+ */
 interface ToolCallRejected {
     type: 'toolCallRejected';
 

src/eca/features/chat.clj

@@ -116,7 +116,6 @@
         all-tools (f.tools/all-tools behavior @db* config)
         received-msgs* (atom "")
         received-thinking* (atom "")
-        tool-call-by-id* (atom {:args {}})
         add-to-history! (fn [msg]
                           (swap! db* update-in [:chats chat-id :messages] (fnil conj []) msg))]
 
@@ -165,13 +164,12 @@
                                          (finish-chat-prompt! :idle chat-ctx))))
       :on-prepare-tool-call (fn [{:keys [id name arguments-text]}]
                               (assert-chat-not-stopped! chat-ctx)
-                              (swap! tool-call-by-id* update-in [id :args] str arguments-text)
                               (send-content! chat-ctx :assistant
                                              (assoc-some
                                               {:type :toolCallPrepare
                                                :name name
                                                :origin (tool-name->origin name all-tools)
-                                               :arguments-text (get-in @tool-call-by-id* [id :args])
+                                               :arguments-text arguments-text
                                                :id id
                                                :manual-approval (f.tools/manual-approval? name config)}
                                               :summary (f.tools/tool-call-summary all-tools name nil))))
@@ -248,8 +246,7 @@
                                                                  :reason :user
                                                                  :id id}
                                                                 :details details
-                                                                :summary summary))))
-                                            (swap! tool-call-by-id* dissoc id)))))]
+                                                                :summary summary))))))))]
                            ;; Wait all tool calls to complete before returning
                            (run! deref calls)
                            (send-content! chat-ctx :system {:type :progress :state :running :text "Generating"})