Fix tests

Author: ericdallo

src/eca/features/chat.clj

@@ -874,8 +874,9 @@
                                                   config)
         image-contents (->> refined-contexts
                             (filter #(= :image (:type %))))
-        expanded-prompt-contexts (when-let [contexts-str (-> (f.context/contexts-str-from-prompt message db)
-                                                             (f.prompt/contexts-str repo-map*))]
+        expanded-prompt-contexts (when-let [contexts-str (some-> (f.context/contexts-str-from-prompt message db)
+                                                                 seq
+                                                                 (f.prompt/contexts-str repo-map*))]
                                    [{:type :text :text contexts-str}])
         user-messages [{:role "user" :content (concat [{:type :text :text message}]
                                                       expanded-prompt-contexts

src/eca/shared.clj

@@ -162,7 +162,7 @@
    The cache key includes the file's last-modified timestamp, so the cache
    automatically invalidates when the file changes."
   [f]
-  (let [mf (memoize/memo (fn [file mtime & args]
+  (let [mf (memoize/memo (fn [file _mtime & args]
                            (apply f file args)))
         safe-mtime (fn [file]
                      (try

test/eca/features/context_test.clj

@@ -41,7 +41,7 @@
               {:type "file" :path (h/file-path (str root "/dir/nested.txt"))}
               {:type "file" :path (h/file-path (str root "/bar.txt"))}
               {:type "mcpResource" :uri "mcp://r1"}]
-             (f.context/all-contexts nil (h/db*) (h/config)))))))
+             (f.context/all-contexts nil false (h/db*) (h/config)))))))
 
   (testing "respects the query by limiting glob results"
     (h/reset-components!)
@@ -57,7 +57,7 @@
                     fs/canonicalize identity
                     f.index/filter-allowed (fn [file-paths _root _config] file-paths)
                     f.mcp/all-resources (fn [_db] [])]
-        (let [result (f.context/all-contexts "foo" (h/db*) {})]
+        (let [result (f.context/all-contexts "foo" false (h/db*) {})]
           ;; Should include foo.txt but not bar.txt
           (is (some #(= {:type "file" :path (str root "/foo.txt")} %) result))
           (is (not (some #(= {:type "file" :path (str root "/bar.txt")} %) result)))))))
@@ -85,7 +85,7 @@
                     fs/canonicalize identity
                     f.index/filter-allowed (fn [file-paths _root _config] file-paths)
                     f.mcp/all-resources (fn [_db] [])]
-        (let [result (f.context/all-contexts nil (h/db*) {})]
+        (let [result (f.context/all-contexts nil false (h/db*) {})]
           ;; Root directories present
           (is (some #(= {:type "directory" :path root1} %) result))
           (is (some #(= {:type "directory" :path root2} %) result))
@@ -107,7 +107,7 @@
                     f.index/filter-allowed (fn [files _root _config] files)]
         (let [db* (atom {:workspace-folders [{:uri (h/file-uri "file:///fake/repo")}]})
               config {}
-              results (f.context/all-contexts "readme" db* config)
+              results (f.context/all-contexts "readme" false db* config)
               file-paths (->> results (filter #(= "file" (:type %))) (map :path) set)]
           (is (contains? file-paths readme)))))))
 
@@ -128,7 +128,7 @@
                     fs/canonicalize identity
                     f.index/filter-allowed (fn [file-paths _root _config] file-paths)
                     f.mcp/all-resources (fn [_] [])]
-        (let [result (f.context/all-contexts "./src" db* {})]
+        (let [result (f.context/all-contexts "./src" false db* {})]
           ;; Root directory present
           (is (some #(= {:type "directory" :path root} %) result))
           ;; Entries mapped from the relative listing
@@ -154,7 +154,7 @@
                     fs/canonicalize identity
                     f.index/filter-allowed (fn [file-paths _root _config] file-paths)
                     f.mcp/all-resources (fn [_] [])]
-        (let [result (f.context/all-contexts "./missing/file" db* {})]
+        (let [result (f.context/all-contexts "./missing/file" false db* {})]
           ;; Root directory present
           (is (some #(= {:type "directory" :path root} %) result))
           ;; Entries mapped from the parent listing
@@ -179,7 +179,7 @@
                     fs/canonicalize identity
                     f.index/filter-allowed (fn [file-paths _root _config] file-paths)
                     f.mcp/all-resources (fn [_] [])]
-        (let [result (f.context/all-contexts "~" db* {})]
+        (let [result (f.context/all-contexts "~" false db* {})]
           ;; Root directory present
           (is (some #(= {:type "directory" :path root} %) result))
           ;; Entries from home listing

test/eca/features/prompt_test.clj

@@ -19,7 +19,7 @@
       (is (string/includes? result "<rules description=\"Rules defined by user\">"))
       (is (string/includes? result "<rule name=\"rule1\">First rule</rule>"))
       (is (string/includes? result "<rule name=\"rule2\">Second rule</rule>"))
-      (is (string/includes? result "<contexts description=\"Manually provided by user, usually when provided user knows that your task is related to those files, so consider reliying on it, if not enough, use tools to read/gather any extra files/contexts.\">"))
+      (is (string/includes? result "<contexts description=\"Manually Provided by user. Their content is current and accurate. You MUST use this information first before using tools to read them.\">"))
       (is (string/includes? result "<file path=\"foo.clj\">(ns foo)</file>"))
       (is (string/includes? result "<file partial=true path=\"bar.clj\">...\n(def a 1)\n...</file>"))
       (is (string/includes? result "<repoMap description=\"Workspaces structure in a tree view, spaces represent file hierarchy\" >TREE</repoMap>"))
@@ -40,7 +40,7 @@
       (is (string/includes? result "<rules description=\"Rules defined by user\">"))
       (is (string/includes? result "<rule name=\"rule1\">First rule</rule>"))
       (is (string/includes? result "<rule name=\"rule2\">Second rule</rule>"))
-      (is (string/includes? result "<contexts description=\"Manually provided by user, usually when provided user knows that your task is related to those files, so consider reliying on it, if not enough, use tools to read/gather any extra files/contexts.\">"))
+      (is (string/includes? result "<contexts description=\"Manually Provided by user. Their content is current and accurate. You MUST use this information first before using tools to read them.\">"))
       (is (string/includes? result "<file path=\"foo.clj\">(ns foo)</file>"))
       (is (string/includes? result "<file partial=true path=\"bar.clj\">...\n(def a 1)\n...</file>"))
       (is (string/includes? result "<repoMap description=\"Workspaces structure in a tree view, spaces represent file hierarchy\" >TREE</repoMap>"))

test/eca/secrets_test.clj

@@ -272,7 +272,7 @@
 
         ;; Mock decrypt-gpg to simulate timeout behavior
         (with-redefs [secrets/gpg-available? (constantly true)
-                      secrets/decrypt-gpg (fn [file-path]
+                      secrets/decrypt-gpg (fn [_file-path]
                                             (reset! decrypt-called? true)
                                             ;; Simulate timeout by returning nil
                                             nil)]
@@ -619,9 +619,9 @@
         (spit temp-path "machine api.openai.com\nlogin apikey\npassword sk-super-secret-password-123\n")
 
         ;; Mock logger to capture messages
-        (with-redefs [logger/debug (fn [tag & args]
+        (with-redefs [logger/debug (fn [_tag & args]
                                      (swap! logged-messages conj (vec args)))
-                      logger/info (fn [tag & args]
+                      logger/info (fn [_tag & args]
                                     (swap! logged-messages conj (vec args)))
                       secrets/credential-file-paths (constantly [temp-path])]
           (let [result (secrets/get-credential "api.openai.com")]
@@ -643,7 +643,7 @@
         (spit temp-path "machine api.openai.com\nlogin apikey\npassword sk-secret-key-789\ngarbage!!!!\n")
 
         ;; Mock logger to capture messages
-        (with-redefs [logger/warn (fn [tag & args]
+        (with-redefs [logger/warn (fn [_tag & args]
                                     (swap! logged-messages conj (vec args)))
                       secrets/credential-file-paths (constantly [temp-path])]
           (secrets/get-credential "api.openai.com")
@@ -738,7 +738,7 @@
               (Files/setPosixFilePermissions path perms)
 
               ;; Mock logger to capture warnings
-              (with-redefs [logger/warn (fn [tag & args]
+              (with-redefs [logger/warn (fn [_tag & args]
                                           (swap! warnings conj (vec args)))
                             secrets/credential-file-paths (constantly [temp-path])]
                 (secrets/get-credential "api.openai.com")
@@ -773,7 +773,7 @@
               (Files/setPosixFilePermissions path perms)
 
               ;; Mock logger to capture warnings
-              (with-redefs [logger/warn (fn [tag & args]
+              (with-redefs [logger/warn (fn [_tag & args]
                                           (swap! warnings conj (vec args)))
                             secrets/credential-file-paths (constantly [temp-path])]
                 (secrets/get-credential "api.openai.com")